[Chromecast] Adding pause/resume operations to VideoPlaneController.

chromecast/media/base/video_plane_controller.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_MEDIA_VIDEO_PLANE_CONTROLLER_H_
 #define CHROMECAST_MEDIA_VIDEO_PLANE_CONTROLLER_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
 #include "base/threading/thread_checker.h"
@@ skipping 26 matching lines @@
  public:
   static VideoPlaneController* GetInstance();
 
   // Sets the video plane geometry (forwards to VideoPlane::SetGeometry)
   // in *graphics plane coordinates*.
   //  * This should be called on UI thread (hopping to media thread is handled
   //    internally).
   // If there is no change to video plane parameters from the last call to this
   // method, it is a no-op.
   void SetGeometry(const RectF& display_rect, VideoPlane::Transform transform);
+  // Posts call to VideoPlane::SetGeometry with most recent resolution and
+  // geometry parameters (assuming they are all set). Use to reset video plane.
+  void ResetGeometry();

[halliwell, 2015/12/28 22:22:31]

nit: blank line before comment.

I don't quite like 'ResetGeometry' function name.  It makes it sound like the
geometry is being reset to a default or initial value.

How about something like ApplyToVideoPlane?  Or even ResetVideoPlane.

[esum, 2016/01/11 16:28:57]

Method no longer needed since resetting the video plane is now an automatic part
of Resume() per Derek's comment:
https://eureka-internal-review.git.corp.google.com/#/c/42141/4/service/resour...

 
   // Sets physical screen resolution.  This must be called at least once when
   // the final output resolution (HDMI signal or panel resolution) is known,
   // then later when it changes. If there is no change to the device resolution
   // from the last call to this method, it is a no-op.
   void SetDeviceResolution(const Size& resolution);
 
   // Sets graphics hardware plane resolution.  This must be called at least once
   // when the hardware graphics plane resolution (same resolution as
   // gfx::Screen) is known, then later when it changes. If there is no change to
   // the graphics plane resolution from the last call to this method, it is a
   // no-op.
   void SetGraphicsPlaneResolution(const Size& resolution);
 
+  // After Pause is called, no further calls to VideoPlane::SetGeometry will be
+  // made except for any pending calls already scheduled on the media thread.
+  // The Set methods will however update cached parameters that will take
+  // effect once the class is resumed. Safe to call multiple times.
+  void Pause();
+  // Makes class active again. Safe to call multiple times.
+  void Resume();
+  bool is_paused() const;
+
  private:
   class RateLimitedSetVideoPlaneGeometry;
   friend struct base::DefaultSingletonTraits<VideoPlaneController>;
 
   VideoPlaneController();
   ~VideoPlaneController();
 
   // Check if HaveDataForSetGeometry. If not, this method is a no-op. Otherwise
   // it scales the display rect from graphics to device resolution coordinates.
   // Then posts task to media thread for VideoPlane::SetGeometry.
   void MaybeRunSetGeometry();
   // Checks if all data has been collected to make calls to
   // VideoPlane::SetGeometry.
   bool HaveDataForSetGeometry() const;
 
+  bool is_paused_;
+
   // Current resolutions
   bool have_output_res_;
   bool have_graphics_res_;
   Size output_res_;
   Size graphics_res_;
 
   // Saved video plane parameters (in graphics plane coordinates)
   // for use when screen resolution changes.
   bool have_video_plane_geometry_;
   RectF video_plane_display_rect_;
   VideoPlane::Transform video_plane_transform_;
 
   scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
   scoped_refptr<RateLimitedSetVideoPlaneGeometry> video_plane_wrapper_;
 
   base::ThreadChecker thread_checker_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoPlaneController);
 };
 
 }  // namespace media
 }  // namespace chromecast
 
 #endif  // CHROMECAST_MEDIA_VIDEO_PLANE_CONTROLLER_H_