Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 1531473006: move functional argument check into manager (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-16 14:51:04 UTC) #2
scheglov
LGTM
5 years ago (2015-12-16 17:01:34 UTC) #3
danrubel
5 years ago (2015-12-16 17:11:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4cd376143fb7016b88f5b47bd9bfff02a4d74631 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698