Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 1531473006: move functional argument check into manager (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
index 4921e5f16f21f2d68f0455750ba7b1640eb2f12b..3d56c873792562172c17ea61c010e2e8b912eb1f 100644
--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
@@ -38,18 +38,6 @@ class LocalReferenceContributor extends DartCompletionContributor {
DartCompletionRequest request) async {
OpType optype = (request as DartCompletionRequestImpl).opType;
- // Resolve the expression in which the completion occurs
- // to properly determine if identifiers should be suggested
- // rather than invocations.
- if (request.target.maybeFunctionalArgument()) {
- Expression expression =
- request.target.containingNode.getAncestor((p) => p is Expression);
- if (expression != null) {
- await request.resolveExpression(expression);
- optype = (request as DartCompletionRequestImpl).opType;
- }
- }
-
// Collect suggestions from the specific child [AstNode] that contains
// the completion offset and all of its parents recursively.
if (!optype.isPrefixed) {
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698