Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1531423003: Revert of Repeating SkBitmapProcState rounding bias (Closed)

Created:
5 years ago by f(malita)
Modified:
5 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Repeating SkBitmapProcState rounding bias (patchset #6 id:100001 of https://codereview.chromium.org/1529833003/ ) Reason for revert: We need a SkFractionalInt auto mapper flavor, otherwise we're losing precision for some procs => seaming artifacs (https://gold.skia.org/diff?test=giantbitmap_mirror_point_rotate&left=0dd7a412fce81586e6a142e039ec2de9&top=a706d4bb2b8e994b936445b87115b07e) Original issue's description: > Repeating SkBitmapProcState rounding bias > > Observe the bias in repeat matrix procs also. > > Introduce a utility class to handle device space -> bitmap space > mapping. > > BUG=skia:4680, skia:4649 > R=reed@google.com > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1529833003 > > Committed: https://skia.googlesource.com/skia/+/5ae7fdcc3d7712da3193c39a751e88b092aa82db TBR=reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4680, skia:4649 Committed: https://skia.googlesource.com/skia/+/3e6be16e6d4dda6a27f0e1dbfe7c87fecfbf5577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -45 lines) Patch
M src/core/SkBitmapProcState.h View 2 chunks +12 lines, -29 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcState_matrix.h View 2 chunks +15 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState_matrix_template.h View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
f(malita)
Created Revert of Repeating SkBitmapProcState rounding bias
5 years ago (2015-12-18 17:36:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531423003/1
5 years ago (2015-12-18 17:36:08 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-18 17:36:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3e6be16e6d4dda6a27f0e1dbfe7c87fecfbf5577

Powered by Google App Engine
This is Rietveld 408576698