Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/core/SkBitmapProcState_matrix_template.h

Issue 1531423003: Revert of Repeating SkBitmapProcState rounding bias (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkBitmapProcState_matrix.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkBitmapProcState_MatrixTemplates_DEFINED 8 #ifndef SkBitmapProcState_MatrixTemplates_DEFINED
9 #define SkBitmapProcState_MatrixTemplates_DEFINED 9 #define SkBitmapProcState_MatrixTemplates_DEFINED
10 10
11 #include "SkMath.h" 11 #include "SkMath.h"
12 #include "SkMathPriv.h" 12 #include "SkMathPriv.h"
13 13
14 template <typename TileProc, bool tryDecal> 14 template <typename TileProc, bool tryDecal>
15 void NoFilterProc_Scale(const SkBitmapProcState& s, uint32_t xy[], 15 void NoFilterProc_Scale(const SkBitmapProcState& s, uint32_t xy[],
16 int count, int x, int y) { 16 int count, int x, int y) {
17 SkASSERT((s.fInvType & ~(SkMatrix::kTranslate_Mask | 17 SkASSERT((s.fInvType & ~(SkMatrix::kTranslate_Mask |
18 SkMatrix::kScale_Mask)) == 0); 18 SkMatrix::kScale_Mask)) == 0);
19 19
20 // we store y, x, x, x, x, x 20 // we store y, x, x, x, x, x
21 21
22 const unsigned maxX = s.fPixmap.width() - 1; 22 const unsigned maxX = s.fPixmap.width() - 1;
23 SkFractionalInt fx; 23 SkFractionalInt fx;
24 { 24 {
25 const SkBitmapProcStateAutoMapper mapper(s, x ,y); 25 SkPoint pt;
26 s.fInvProc(s.fInvMatrix, SkIntToScalar(x) + SK_ScalarHalf,
27 SkIntToScalar(y) + SK_ScalarHalf, &pt);
28 fx = SkScalarToFractionalInt(pt.fY);
26 const unsigned maxY = s.fPixmap.height() - 1; 29 const unsigned maxY = s.fPixmap.height() - 1;
27 *xy++ = TileProc::Y(s, mapper.y(), maxY); 30 *xy++ = TileProc::Y(s, SkFractionalIntToFixed(fx), maxY);
28 fx = SkFixedToFractionalInt(mapper.x()); 31 fx = SkScalarToFractionalInt(pt.fX);
29 } 32 }
30 33
31 if (0 == maxX) { 34 if (0 == maxX) {
32 // all of the following X values must be 0 35 // all of the following X values must be 0
33 memset(xy, 0, count * sizeof(uint16_t)); 36 memset(xy, 0, count * sizeof(uint16_t));
34 return; 37 return;
35 } 38 }
36 39
37 const SkFractionalInt dx = s.fInvSxFractionalInt; 40 const SkFractionalInt dx = s.fInvSxFractionalInt;
38 41
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 // SCALE's inner loop that only looks at dx 73 // SCALE's inner loop that only looks at dx
71 74
72 template <typename TileProc> 75 template <typename TileProc>
73 void NoFilterProc_Affine(const SkBitmapProcState& s, uint32_t xy[], 76 void NoFilterProc_Affine(const SkBitmapProcState& s, uint32_t xy[],
74 int count, int x, int y) { 77 int count, int x, int y) {
75 SkASSERT(s.fInvType & SkMatrix::kAffine_Mask); 78 SkASSERT(s.fInvType & SkMatrix::kAffine_Mask);
76 SkASSERT((s.fInvType & ~(SkMatrix::kTranslate_Mask | 79 SkASSERT((s.fInvType & ~(SkMatrix::kTranslate_Mask |
77 SkMatrix::kScale_Mask | 80 SkMatrix::kScale_Mask |
78 SkMatrix::kAffine_Mask)) == 0); 81 SkMatrix::kAffine_Mask)) == 0);
79 82
80 const SkBitmapProcStateAutoMapper mapper(s, x ,y); 83 SkPoint srcPt;
81 SkFractionalInt fx = SkFixedToFractionalInt(mapper.x()); 84 s.fInvProc(s.fInvMatrix,
82 SkFractionalInt fy = SkFixedToFractionalInt(mapper.y()); 85 SkIntToScalar(x) + SK_ScalarHalf,
86 SkIntToScalar(y) + SK_ScalarHalf, &srcPt);
87
88 SkFractionalInt fx = SkScalarToFractionalInt(srcPt.fX);
89 SkFractionalInt fy = SkScalarToFractionalInt(srcPt.fY);
83 SkFractionalInt dx = s.fInvSxFractionalInt; 90 SkFractionalInt dx = s.fInvSxFractionalInt;
84 SkFractionalInt dy = s.fInvKyFractionalInt; 91 SkFractionalInt dy = s.fInvKyFractionalInt;
85 int maxX = s.fPixmap.width() - 1; 92 int maxX = s.fPixmap.width() - 1;
86 int maxY = s.fPixmap.height() - 1; 93 int maxY = s.fPixmap.height() - 1;
87 94
88 for (int i = count; i > 0; --i) { 95 for (int i = count; i > 0; --i) {
89 *xy++ = (TileProc::Y(s, SkFractionalIntToFixed(fy), maxY) << 16) | 96 *xy++ = (TileProc::Y(s, SkFractionalIntToFixed(fy), maxY) << 16) |
90 TileProc::X(s, SkFractionalIntToFixed(fx), maxX); 97 TileProc::X(s, SkFractionalIntToFixed(fx), maxX);
91 fx += dx; fy += dy; 98 fx += dx; fy += dy;
92 } 99 }
93 } 100 }
94 101
95 template <typename TileProc> 102 template <typename TileProc>
96 void NoFilterProc_Persp(const SkBitmapProcState& s, uint32_t* SK_RESTRICT xy, 103 void NoFilterProc_Persp(const SkBitmapProcState& s, uint32_t* SK_RESTRICT xy,
97 int count, int x, int y) { 104 int count, int x, int y) {
98 SkASSERT(s.fInvType & SkMatrix::kPerspective_Mask); 105 SkASSERT(s.fInvType & SkMatrix::kPerspective_Mask);
99 106
100 int maxX = s.fPixmap.width() - 1; 107 int maxX = s.fPixmap.width() - 1;
101 int maxY = s.fPixmap.height() - 1; 108 int maxY = s.fPixmap.height() - 1;
102 109
103 // TODO: inv bias support
104 SkPerspIter iter(s.fInvMatrix, 110 SkPerspIter iter(s.fInvMatrix,
105 SkIntToScalar(x) + SK_ScalarHalf, 111 SkIntToScalar(x) + SK_ScalarHalf,
106 SkIntToScalar(y) + SK_ScalarHalf, count); 112 SkIntToScalar(y) + SK_ScalarHalf, count);
107 113
108 while ((count = iter.next()) != 0) { 114 while ((count = iter.next()) != 0) {
109 const SkFixed* SK_RESTRICT srcXY = iter.getXY(); 115 const SkFixed* SK_RESTRICT srcXY = iter.getXY();
110 while (--count >= 0) { 116 while (--count >= 0) {
111 *xy++ = (TileProc::Y(s, srcXY[1], maxY) << 16) | 117 *xy++ = (TileProc::Y(s, srcXY[1], maxY) << 16) |
112 TileProc::X(s, srcXY[0], maxX); 118 TileProc::X(s, srcXY[0], maxX);
113 srcXY += 2; 119 srcXY += 2;
114 } 120 }
115 } 121 }
116 } 122 }
117 123
118 #endif 124 #endif
OLDNEW
« no previous file with comments | « src/core/SkBitmapProcState_matrix.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698