Fix regression in SSE instruction opcodes

Fix regression in SSE instruction opcodes

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=19413a5663260165201a0c90a4354c54bf2c5e77

[sehr, 2015-12-18 00:48:11]

Description was changed from

==========
Fix regression in SSE instruction opcodes

BUG=
==========

to

==========
Fix regression in SSE instruction opcodes

BUG=
==========

[sehr, 2015-12-18 00:48:11]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[sehr, 2015-12-18 00:48:24]

Sorry for the regression.  PTAL.

[Jim Stichnoth, 2015-12-18 00:49:54]

lgtm

[John, 2015-12-18 00:50:03]

lgtm

https://codereview.chromium.org/1531303004/diff/1/src/IceInstX86Base.h
File src/IceInstX86Base.h (left):

https://codereview.chromium.org/1531303004/diff/1/src/IceInstX86Base.h#oldcod...
src/IceInstX86Base.h:3077: template <> const char
*InstX86Addps<Machine>::Base::Opcode = "addps";       \
It saddens me that the Instruction is named Addps, but its opcode is "add"

[sehr, 2015-12-18 00:52:12]

Thx.

https://codereview.chromium.org/1531303004/diff/1/src/IceInstX86Base.h
File src/IceInstX86Base.h (left):

https://codereview.chromium.org/1531303004/diff/1/src/IceInstX86Base.h#oldcod...
src/IceInstX86Base.h:3077: template <> const char
*InstX86Addps<Machine>::Base::Opcode = "addps";       \
On 2015/12/18 00:50:03, John wrote:
> It saddens me that the Instruction is named Addps, but its opcode is "add"

We need a new name for the class (probably with XMM or SSE in it).  And it needs
to be distinct from Addss and Add...  Taxonomies -- hard work.

[sehr, 2015-12-18 00:53:15]

Description was changed from

==========
Fix regression in SSE instruction opcodes

BUG=
==========

to

==========
Fix regression in SSE instruction opcodes

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[sehr, 2015-12-18 00:53:17]

Committed patchset #1 (id:1) manually as
19413a5663260165201a0c90a4354c54bf2c5e77 (presubmit successful).