Compute all default values of parameters.

Compute all default values of parameters.

Look at the following code.

main([p = double.INFINITY]) {}

In ConstantVerifier we validate the value of "p" and while doing this validate
the value of the ConstFieldElementImpl that corresponds to "double.INFINITY".

The problem is that we compute "double.INFINITY" in the task that requires
RESOLVED_UNIT_n, where "n" is too high. What we really need is just one value,
not all values, and of course not the resolved unit. And when we will use
summaries, we will be able to provide these values without using AST at all.

So, we need to explicitly require computation of the default value of "p",
an explicit dependency on "double.INFINITY" and its explicit computation.
Currently it still causes using ASTs, but we will change this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9801d58eb7d6cf96f1a0c50aac59065ea0dec2ae

[Paul Berry, 2015-12-17 15:05:47]

lgtm

https://codereview.chromium.org/1531233002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/driver.dart (right):

https://codereview.chromium.org/1531233002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/driver.dart:552: final int level;
Doc comment missing - did you leave this code in by accident?

https://codereview.chromium.org/1531233002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/driver.dart:603: //    print('${'\t' *
level}$spawningResult of $actualTarget');
Looks like this was left in by accident too

[Brian Wilkerson, 2015-12-17 15:12:40]

Description was changed from

==========
Compute all default values of parameters.

Look at the following code.

main([p = double.INFINITY]) {}

In ConstantVerifier we validate the value of "p" and while doing this validate
the value of the ConstFieldElementImpl that corresponds to "double.INFINITY".

The problem is that we compute "double.INFINITY" in the task that requires
RESOLVED_UNIT_n, where "n" is too high. What we really need is just one value,
not all values, and of course not the resolved unit. And when we will use
summaries, we will be able to provide these values without using AST at all.

So, we need to explicitly require computation of the default value of "p",
an explicit dependency on "double.INFINITY" and its explicit computation.
Currently it still causes using ASTs, but we will change this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute all default values of parameters.

Look at the following code.

main([p = double.INFINITY]) {}

In ConstantVerifier we validate the value of "p" and while doing this validate
the value of the ConstFieldElementImpl that corresponds to "double.INFINITY".

The problem is that we compute "double.INFINITY" in the task that requires
RESOLVED_UNIT_n, where "n" is too high. What we really need is just one value,
not all values, and of course not the resolved unit. And when we will use
summaries, we will be able to provide these values without using AST at all.

So, we need to explicitly require computation of the default value of "p",
an explicit dependency on "double.INFINITY" and its explicit computation.
Currently it still causes using ASTs, but we will change this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

[Brian Wilkerson, 2015-12-17 15:13:01]

LGTM

[scheglov, 2015-12-17 16:06:14]

Description was changed from

==========
Compute all default values of parameters.

Look at the following code.

main([p = double.INFINITY]) {}

In ConstantVerifier we validate the value of "p" and while doing this validate
the value of the ConstFieldElementImpl that corresponds to "double.INFINITY".

The problem is that we compute "double.INFINITY" in the task that requires
RESOLVED_UNIT_n, where "n" is too high. What we really need is just one value,
not all values, and of course not the resolved unit. And when we will use
summaries, we will be able to provide these values without using AST at all.

So, we need to explicitly require computation of the default value of "p",
an explicit dependency on "double.INFINITY" and its explicit computation.
Currently it still causes using ASTs, but we will change this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute all default values of parameters.

Look at the following code.

main([p = double.INFINITY]) {}

In ConstantVerifier we validate the value of "p" and while doing this validate
the value of the ConstFieldElementImpl that corresponds to "double.INFINITY".

The problem is that we compute "double.INFINITY" in the task that requires
RESOLVED_UNIT_n, where "n" is too high. What we really need is just one value,
not all values, and of course not the resolved unit. And when we will use
summaries, we will be able to provide these values without using AST at all.

So, we need to explicitly require computation of the default value of "p",
an explicit dependency on "double.INFINITY" and its explicit computation.
Currently it still causes using ASTs, but we will change this soon.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9801d58eb7d6cf96f1a0c50aac59065ea0dec2ae
==========

[scheglov, 2015-12-17 16:06:15]

Committed patchset #1 (id:1) manually as
9801d58eb7d6cf96f1a0c50aac59065ea0dec2ae (presubmit successful).