Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: pkg/analyzer/lib/src/task/driver.dart

Issue 1531233002: Compute all default values of parameters. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/test/generated/non_error_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/driver.dart
diff --git a/pkg/analyzer/lib/src/task/driver.dart b/pkg/analyzer/lib/src/task/driver.dart
index c5bc0768ed87df66e5fab42037423cccbc5280e8..ddc919b4ba43d45366b4e4b4521d16be16a57a22 100644
--- a/pkg/analyzer/lib/src/task/driver.dart
+++ b/pkg/analyzer/lib/src/task/driver.dart
@@ -46,8 +46,8 @@ class AnalysisDriver {
/**
* The map of [ComputedResult] controllers.
*/
- final Map<ResultDescriptor,
- StreamController<ComputedResult>> resultComputedControllers =
+ final Map<ResultDescriptor, StreamController<ComputedResult>>
+ resultComputedControllers =
<ResultDescriptor, StreamController<ComputedResult>>{};
/**
@@ -168,7 +168,7 @@ class AnalysisDriver {
TaskDescriptor taskDescriptor = taskManager.findTask(target, result);
try {
WorkItem workItem =
- new WorkItem(context, target, taskDescriptor, result, null);
+ new WorkItem(context, target, taskDescriptor, result, 0, null);
return new WorkOrder(taskManager, workItem);
} catch (exception, stackTrace) {
throw new AnalysisException(
@@ -549,6 +549,8 @@ class WorkItem {
*/
final ResultDescriptor spawningResult;
+ final int level;
Paul Berry 2015/12/17 15:05:47 Doc comment missing - did you leave this code in b
+
/**
* The work order that this item is part of, may be `null`.
*/
@@ -593,11 +595,12 @@ class WorkItem {
* described by the given descriptor.
*/
WorkItem(this.context, this.target, this.descriptor, this.spawningResult,
- this.workOrder) {
+ this.level, this.workOrder) {
AnalysisTarget actualTarget =
identical(target, AnalysisContextTarget.request)
? new AnalysisContextTarget(context)
: target;
+// print('${'\t' * level}$spawningResult of $actualTarget');
Paul Berry 2015/12/17 15:05:47 Looks like this was left in by accident too
Map<String, TaskInput> inputDescriptors =
descriptor.createTaskInputs(actualTarget);
builder = new TopLevelTaskInputBuilder(inputDescriptors);
@@ -699,8 +702,8 @@ class WorkItem {
try {
TaskDescriptor descriptor =
taskManager.findTask(inputTarget, inputResult);
- return new WorkItem(
- context, inputTarget, descriptor, inputResult, workOrder);
+ return new WorkItem(context, inputTarget, descriptor, inputResult,
+ level + 1, workOrder);
} on AnalysisException catch (exception, stackTrace) {
this.exception = new CaughtException(exception, stackTrace);
return null;
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/test/generated/non_error_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698