Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1531153002: Android: Set Surface namespace for browser compositor (Closed)

Created:
5 years ago by no sievers
Modified:
5 years ago
Reviewers:
jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Set Surface namespace for browser compositor This causes a subtle bug where surfaces are always garbage collected because the namespace is invalid. Committed: https://crrev.com/c9bb949e1cf6028063715e87063f812887b5d3a2 Cr-Commit-Position: refs/heads/master@{#365721}

Patch Set 1 #

Patch Set 2 : null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jbauman
Oops. lgtm.
5 years ago (2015-12-17 00:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531153002/20001
5 years ago (2015-12-17 00:33:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 03:45:42 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 03:46:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9bb949e1cf6028063715e87063f812887b5d3a2
Cr-Commit-Position: refs/heads/master@{#365721}

Powered by Google App Engine
This is Rietveld 408576698