Fix image filter crop offsets for GPU path.

Fix image filter crop offsets for GPU path.

This is the GPU-side version of
https://codereview.chromium.org/112803004/.
Also factored the crop offset unit test into a function, so we can
call it with both CPU & GPU devices.

R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13292

[Stephen White, 2014-02-03 21:03:58]

PTAL. Thanks!

[bsalomon, 2014-02-03 21:31:08]

lgtm

https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp#n...
src/core/SkImageFilter.cpp:152: if
(!SkImageFilterUtils::GetInputResultGPU(this->getInput(0), proxy, src, ctm,
&input, &srcOffset)) {
if all the callers now pass a non-NULL value maybe this should be a required
const& param?

[Stephen White, 2014-02-03 21:35:10]

On 2014/02/03 21:31:08, bsalomon wrote:
> lgtm
> 
> https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp
> File src/core/SkImageFilter.cpp (right):
> 
>
https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp#n...
> src/core/SkImageFilter.cpp:152: if
> (!SkImageFilterUtils::GetInputResultGPU(this->getInput(0), proxy, src, ctm,
> &input, &srcOffset)) {
> if all the callers now pass a non-NULL value maybe this should be a required
> const& param?

You mean the offset? It's an outparam, so it needs to be writeable. That means
it
has to be a ptr, AFAIK.

[bsalomon, 2014-02-03 21:45:00]

On 2014/02/03 21:35:10, Stephen White wrote:
> On 2014/02/03 21:31:08, bsalomon wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp
> > File src/core/SkImageFilter.cpp (right):
> > 
> >
>
https://codereview.chromium.org/153113003/diff/1/src/core/SkImageFilter.cpp#n...
> > src/core/SkImageFilter.cpp:152: if
> > (!SkImageFilterUtils::GetInputResultGPU(this->getInput(0), proxy, src, ctm,
> > &input, &srcOffset)) {
> > if all the callers now pass a non-NULL value maybe this should be a required
> > const& param?
> 
> You mean the offset? It's an outparam, so it needs to be writeable. That means
> it
> has to be a ptr, AFAIK.

oh duh.. misread it.

[Stephen White, 2014-02-03 22:22:23]

Committed patchset #1 manually as r13292 (presubmit successful).