Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 153113002: Revert 247831 "Use the proper name for the app info protobuf to ..." (Closed)

Created:
6 years, 10 months ago by Pete Williamson
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dmascarenhas_etouch.net
Visibility:
Public.

Description

Revert 247831 "Use the proper name for the app info protobuf to ..." It seems to be causing sync to fail for the official build on a fresh directory. > Use the proper name for the app info protobuf to mach the sync server > > BUG=339094 > > Review URL: https://codereview.chromium.org/149723003 TBR=petewil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/sync/syncable/model_type.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Pete Williamson
6 years, 10 months ago (2014-02-03 20:41:57 UTC) #1
Pete Williamson
Committed patchset #1 manually as r248568.
6 years, 10 months ago (2014-02-03 20:42:06 UTC) #2
Pete Williamson
Submitted manually via drover. Word from the tester is that this appears to break sync ...
6 years, 10 months ago (2014-02-03 20:44:11 UTC) #3
rlarocque
On 2014/02/03 20:44:11, Pete Williamson wrote: > Submitted manually via drover. > > Word from ...
6 years, 10 months ago (2014-02-03 20:52:51 UTC) #4
Pete Williamson
On 2014/02/03 20:52:51, rlarocque wrote: > On 2014/02/03 20:44:11, Pete Williamson wrote: > > Submitted ...
6 years, 10 months ago (2014-02-03 21:11:52 UTC) #5
Pete Williamson
6 years, 10 months ago (2014-02-03 21:12:18 UTC) #6
Message was sent while issue was closed.
Adding dmascarenhas@etouch.net to the thread.

Powered by Google App Engine
This is Rietveld 408576698