Use the proper name for the app info protobuf to mach the sync server

Use the proper name for the app info protobuf to mach the sync server

BUG=339094
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247831

[Pete Williamson, 2014-01-29 19:55:12]

The name of the data type did not match the server, causing problems.  Zea is
checking in a fix to disable the data type, but we should also fix the name.

[rlarocque, 2014-01-29 20:17:17]

From the client's side, this looks a bit odd.  The other model types seem to
stick to a naming convention.  Is there a good reason why this type should be
different?

LGTM since I don't think style considerations should block you from fixing this
and continuing your work.

Would it be possible for a future CL to change either the server side or client
side code in order to make the names consistent?  Or have too many clients seen
it and now we're stuck with it?

[commit-bot: I haz the power, 2014-01-29 20:52:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petewil@chromium.org/149723003/1

[Pete Williamson, 2014-01-29 20:53:14]

On 2014/01/29 20:17:17, rlarocque wrote:
> From the client's side, this looks a bit odd.  The other model types seem to
> stick to a naming convention.  Is there a good reason why this type should be
> different?
> 
> LGTM since I don't think style considerations should block you from fixing
this
> and continuing your work.
> 
> Would it be possible for a future CL to change either the server side or
client
> side code in order to make the names consistent?  Or have too many clients
seen
> it and now we're stuck with it?

I have a follow up checking coming which is a good opportunity to change the
names.   In this case, we can reverse this specific change, but only if we make
a corresponding change on the server.  I'll talk with Kevin on the Sync team
about if that change makes sense.

[commit-bot: I haz the power, 2014-01-30 04:14:46]

Change committed as 247831