Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1531043002: Revert of [es6] ship regexp sticky flag. (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
Yang
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] ship regexp sticky flag. (patchset #2 id:20001 of https://codereview.chromium.org/1509733010/ ) Reason for revert: This causes compatibility issues, as documented in https://bugs.chromium.org/p/v8/issues/detail?id=4617#c9 Original issue's description: > [es6] ship regexp sticky flag. > > R=littledan@chromium.org > BUG=v8:4342 > LOG=Y > > Committed: https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 > Cr-Commit-Position: refs/heads/master@{#32826} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/flag-definitions.h View 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regexp-not-sticky-yet.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Dan Ehrenberg
Created Revert of [es6] ship regexp sticky flag.
5 years ago (2015-12-16 20:59:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531043002/1
5 years ago (2015-12-16 20:59:07 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/flag-definitions.h: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-16 20:59:15 UTC) #4
Dan Ehrenberg
5 years ago (2015-12-22 06:38:02 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1540263004/ by littledan@chromium.org.

The reason for reverting is: This can be relanded since the web compatibility
fix in https://codereview.chromium.org/1543723002 has been submitted..

Powered by Google App Engine
This is Rietveld 408576698