Use clampTo instead of chaining std::max(std::min(...))

third_party/WebKit/Source/platform/audio/HRTFKernel.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 17 matching lines @@
 
 #include "config.h"
 
 #if ENABLE(WEB_AUDIO)
 
 #include "platform/audio/HRTFKernel.h"
 
 #include "platform/audio/AudioChannel.h"
 #include "platform/FloatConversion.h"
 #include "wtf/MathExtras.h"
+#include <algorithm>

[Raymond Toy, 2015/12/17 19:45:55]

Why is algorithm needed now?

[Daniel Bratell, 2015/12/17 22:56:16]

The code still uses std::min in the HRTFKernel constructor. It used to rely on
someone else(TM) to include <algorithm> but that someone else may be going away.

 
 namespace blink {
 
 // Takes the input AudioChannel as an input impulse response and calculates the average group delay.
 // This represents the initial delay before the most energetic part of the impulse response.
 // The sample-frame delay is removed from the impulseP impulse response, and this value  is returned.
 // the length of the passed in AudioChannel must be a power of 2.
 static float extractAverageGroupDelay(AudioChannel* channel, size_t analysisFFTSize)
 {
     ASSERT(channel);
@@ skipping 59 matching lines @@
 }
 
 // Interpolates two kernels with x: 0 -> 1 and returns the result.
 PassOwnPtr<HRTFKernel> HRTFKernel::createInterpolatedKernel(HRTFKernel* kernel1, HRTFKernel* kernel2, float x)
 {
     ASSERT(kernel1 && kernel2);
     if (!kernel1 || !kernel2)
         return nullptr;
 
     ASSERT(x >= 0.0 && x < 1.0);
-    x = std::min(1.0f, std::max(0.0f, x));
+    x = clampTo(x, 0.0f, 1.0f);
 
     float sampleRate1 = kernel1->sampleRate();
     float sampleRate2 = kernel2->sampleRate();
     ASSERT(sampleRate1 == sampleRate2);
     if (sampleRate1 != sampleRate2)
         return nullptr;
 
     float frameDelay = (1 - x) * kernel1->frameDelay() + x * kernel2->frameDelay();
 
     OwnPtr<FFTFrame> interpolatedFrame = FFTFrame::createInterpolatedFrame(*kernel1->fftFrame(), *kernel2->fftFrame(), x);
     return HRTFKernel::create(interpolatedFrame.release(), frameDelay, sampleRate1);
 }
 
 } // namespace blink
 
 #endif // ENABLE(WEB_AUDIO)