Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handling that minimumThumbLength > trackLen. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 14 matching lines...) Expand all
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #include "config.h" 29 #include "config.h"
30 30
31 #if ENABLE(WEB_AUDIO) 31 #if ENABLE(WEB_AUDIO)
32 32
33 #include "platform/audio/HRTFDatabase.h" 33 #include "platform/audio/HRTFDatabase.h"
34 34
35 #include "wtf/MathExtras.h"
36
35 namespace blink { 37 namespace blink {
36 38
37 const int HRTFDatabase::MinElevation = -45; 39 const int HRTFDatabase::MinElevation = -45;
38 const int HRTFDatabase::MaxElevation = 90; 40 const int HRTFDatabase::MaxElevation = 90;
39 const unsigned HRTFDatabase::RawElevationAngleSpacing = 15; 41 const unsigned HRTFDatabase::RawElevationAngleSpacing = 15;
40 const unsigned HRTFDatabase::NumberOfRawElevations = 10; // -45 -> +90 (each 15 degrees) 42 const unsigned HRTFDatabase::NumberOfRawElevations = 10; // -45 -> +90 (each 15 degrees)
41 const unsigned HRTFDatabase::InterpolationFactor = 1; 43 const unsigned HRTFDatabase::InterpolationFactor = 1;
42 const unsigned HRTFDatabase::NumberOfTotalElevations = NumberOfRawElevations * I nterpolationFactor; 44 const unsigned HRTFDatabase::NumberOfTotalElevations = NumberOfRawElevations * I nterpolationFactor;
43 45
44 PassOwnPtr<HRTFDatabase> HRTFDatabase::create(float sampleRate) 46 PassOwnPtr<HRTFDatabase> HRTFDatabase::create(float sampleRate)
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 kernelR = 0; 103 kernelR = 0;
102 return; 104 return;
103 } 105 }
104 106
105 hrtfElevation->getKernelsFromAzimuth(azimuthBlend, azimuthIndex, kernelL, ke rnelR, frameDelayL, frameDelayR); 107 hrtfElevation->getKernelsFromAzimuth(azimuthBlend, azimuthIndex, kernelL, ke rnelR, frameDelayL, frameDelayR);
106 } 108 }
107 109
108 unsigned HRTFDatabase::indexFromElevationAngle(double elevationAngle) 110 unsigned HRTFDatabase::indexFromElevationAngle(double elevationAngle)
109 { 111 {
110 // Clamp to allowed range. 112 // Clamp to allowed range.
111 elevationAngle = std::max(static_cast<double>(MinElevation), elevationAngle) ; 113 elevationAngle = clampTo<double, double>(elevationAngle, MinElevation, MaxEl evation);
112 elevationAngle = std::min(static_cast<double>(MaxElevation), elevationAngle) ;
113 114
114 unsigned elevationIndex = static_cast<int>(InterpolationFactor * (elevationA ngle - MinElevation) / RawElevationAngleSpacing); 115 unsigned elevationIndex = static_cast<int>(InterpolationFactor * (elevationA ngle - MinElevation) / RawElevationAngleSpacing);
115 return elevationIndex; 116 return elevationIndex;
116 } 117 }
117 118
118 } // namespace blink 119 } // namespace blink
119 120
120 #endif // ENABLE(WEB_AUDIO) 121 #endif // ENABLE(WEB_AUDIO)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698