Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1530713002: make alpha read back of bgra/rgba work (Closed)

Created:
5 years ago by bsalomon
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@align
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make alpha read back of bgra/rgba work BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530713002

Patch Set 1 #

Patch Set 2 : swizzle dst/blend-const #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -51 lines) Patch
M src/gpu/GrProgramDesc.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 chunks +13 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 6 chunks +40 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 3 chunks +69 lines, -28 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (2 generated)
bsalomon
5 years ago (2015-12-15 21:02:53 UTC) #3
😭

Powered by Google App Engine
This is Rietveld 408576698