Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1525193002: Set GL_PACK_ALIGNMENT before calling glReadPixels (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Set GL_PACK_ALIGNMENT before calling glReadPixels Committed: https://skia.googlesource.com/skia/+/f46a124ddd31ca4053c1719d720a74eb4a3cad6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M include/gpu/GrTypes.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +24 lines, -2 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1530713002 Patch 1
Issue 1530713002 Patch 20001
Issue 1530713002 Patch 40001

Messages

Total messages: 8 (3 generated)
bsalomon
Ran into this while working on RGBA->YUV conversions.
5 years ago (2015-12-15 17:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1525193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1525193002/1
5 years ago (2015-12-15 19:49:58 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-15 19:50:01 UTC) #5
jvanverth1
lgtm
5 years ago (2015-12-15 20:36:19 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 20:37:42 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f46a124ddd31ca4053c1719d720a74eb4a3cad6d

Powered by Google App Engine
This is Rietveld 408576698