Support slot element's fallback content feature

Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm: http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm: http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as fallback contents.
This fallback ability will *chain* recursively. That means we can use *another* slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from `v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>

The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the distribution code.

Committed: https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
Cr-Commit-Position: refs/heads/master@{#367789}

[hayato, 2015-12-16 10:27:18]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 10:27:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530643003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530643003/1

[commit-bot: I haz the power, 2015-12-16 11:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 11:22:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hayato, 2015-12-18 06:01:33]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-12-18 06:01:36]

wip

[commit-bot: I haz the power, 2015-12-18 06:02:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530643003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530643003/20001

[hayato, 2015-12-18 06:14:19]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2015-12-18 06:14:21]

wip

[commit-bot: I haz the power, 2015-12-18 06:15:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530643003/40001

[hayato, 2015-12-18 06:49:04]

Description was changed from

==========
Support slots fallback

WIP

BUG=
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant spec section are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature are not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[hayato, 2015-12-18 06:50:13]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant spec section are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature are not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature are not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[hayato, 2015-12-18 07:01:05]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature are not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[hayato, 2015-12-18 07:01:51]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
v1-slots-fallback2.thml,

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees (which is borrowed from
`v1-slots-fallback2.thml` test):

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[hayato, 2015-12-18 07:02:22]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees (which is borrowed from
`v1-slots-fallback2.thml` test):

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
`v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[hayato, 2015-12-18 07:04:48]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2015-12-18 07:04:49]

PTAL

[commit-bot: I haz the power, 2015-12-18 07:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 07:47:10]

Dry run: This issue passed the CQ dry run.

[kochi, 2016-01-05 07:44:11]

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html
(right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:27: const
fallback1 = host.shadowRoot.querySelector('#fallback2');
#fallback1

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:43: //
TODO(hayato): Support slots fallback feature in the document tree and v0 shadow
tree.
Isn't this tested in other tests?

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp
(right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp:114: if
(node.parentNode() && node.parentNode()->isShadowRoot()) {
Can you add an assertion here (ASSERT(node.isInV0ShadowTree())?

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h (right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h:81: // TODO(hayato):
Rename this to more less-confusing name. This is likely to be misued because
isOpen() includes V0 too.
isOpenOrV0()?

Probably it is better to have a separate CL and should be straightforward.

[hayato, 2016-01-06 05:38:34]

On 2016/01/05 07:44:11, kochi wrote:
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html
> (right):
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:27:
const
> fallback1 = host.shadowRoot.querySelector('#fallback2');
> #fallback1
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:43: //
> TODO(hayato): Support slots fallback feature in the document tree and v0
shadow
> tree.
> Isn't this tested in other tests?
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp
> (right):
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp:114: if
> (node.parentNode() && node.parentNode()->isShadowRoot()) {
> Can you add an assertion here (ASSERT(node.isInV0ShadowTree())?
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h (right):
> 
>
https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h:81: // TODO(hayato):
> Rename this to more less-confusing name. This is likely to be misued because
> isOpen() includes V0 too.
> isOpenOrV0()?
> 
> Probably it is better to have a separate CL and should be straightforward.

Yeah, I can do it in a separate CL.

[hayato, 2016-01-06 05:43:44]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-01-06 05:43:48]

addressed

[commit-bot: I haz the power, 2016-01-06 05:43:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530643003/60001

[hayato, 2016-01-06 05:49:09]

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html
(right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:27: const
fallback1 = host.shadowRoot.querySelector('#fallback2');
On 2016/01/05 07:44:11, kochi wrote:
> #fallback1

Done.

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-in-v0.html:43: //
TODO(hayato): Support slots fallback feature in the document tree and v0 shadow
tree.
On 2016/01/05 07:44:11, kochi wrote:
> Isn't this tested in other tests?

Let me remove this commented-out tests from this CL. I'll add this test in a
follow-up patch, which supports slot.getDistributedNodes() even in a document
tree.

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp
(right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp:114: if
(node.parentNode() && node.parentNode()->isShadowRoot()) {
On 2016/01/05 07:44:11, kochi wrote:
> Can you add an assertion here (ASSERT(node.isInV0ShadowTree())?

No. This code is to support v1 shadow tree, but this code runs for v1 shadow
trees too.

It would be better to exit early if we are not in a v0 shadow tree. Done.

[kochi, 2016-01-06 06:21:34]

lgtm

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp
(right):

https://codereview.chromium.org/1530643003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ComposedTreeTraversal.cpp:114: if
(node.parentNode() && node.parentNode()->isShadowRoot()) {
On 2016/01/06 05:49:09, hayato wrote:
> On 2016/01/05 07:44:11, kochi wrote:
> > Can you add an assertion here (ASSERT(node.isInV0ShadowTree())?
> 
> No. This code is to support v1 shadow tree, but this code runs for v1 shadow
> trees too.
> 
> It would be better to exit early if we are not in a v0 shadow tree. Done.

Acknowledged.

[hayato, 2016-01-06 06:22:45]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-01-06 06:22:45]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-01-06 06:23:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530643003/60001

[commit-bot: I haz the power, 2016-01-06 07:10:55]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
`v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
`v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

[commit-bot: I haz the power, 2016-01-06 07:10:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-06 07:11:50]

Description was changed from

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
`v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>


The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.
==========

to

==========
Support slot element's fallback content feature

The spec discussion is:
- https://github.com/w3c/webcomponents/issues/317

The relevant algorithm sections in the Shadow DOM spec are:
- Distributed nodes algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#distributed-nodes-algorithm
- Composition algorithm:
http://w3c.github.io/webcomponents/spec/shadow/#composition-algorithm

Now, if a slot does not have any assigned node, its child nodes are used as
fallback contents.
This fallback ability will *chain* recursively. That means we can use *another*
slot as a slot's fallback contents.
That gives us a great flexibility to compose a composed tree.

e.g.

Suppose we have the following tree of trees, which is borrowed from
`v1-slots-fallback2.thml` test:

<div id='host'>
  <template data-mode='open'>
    <slot name='slot1'>
      <div id='fallback1'></div>
      <slot name='slot2'>
        <div id='fallback2'></div>
      </slot>
    </slot>
    <slot name='slot3'>
      <slot name='slot4'>
        <div id='fallback3'></div>
      </slot>
    </slot>
  </template>
  <div id='child1' slot='slot2'></div>
</div>

This can be composed into the following composed tree:

<div id='host'>
  <div id='fallback1'></div>
  <div id='child1'></div>
  <div id='fallback3'></div>
</div>

The following feature is not yet supported:

- A slot API, HTMLSlotElement::getDistributedNodes does not work in a document
tree nor v0 shadow tree

I'll support this as separate patches. This requires non-trivial changes to the
distribution code.

Committed: https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
Cr-Commit-Position: refs/heads/master@{#367789}
==========

[commit-bot: I haz the power, 2016-01-06 07:11:51]

Patchset 4 (id:??) landed as
https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
Cr-Commit-Position: refs/heads/master@{#367789}

[Noel Gordon, 2016-01-06 07:34:37]

On 2016/01/06 07:11:51, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
> Cr-Commit-Position: refs/heads/master@{#367789}


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/b...

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=255169-1 ... 
../../third_party/WebKit/Source/build/mac/Prefix.h -c
../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp -o
obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o
In file included from
../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:5:
In file included from
../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:8:
In file included from ../../third_party/WebKit/Source/platform/heap/Handle.h:34:
In file included from ../../third_party/WebKit/Source/platform/heap/Heap.h:35:
In file included from ../../third_party/WebKit/Source/platform/heap/GCInfo.h:8:
In file included from
../../third_party/WebKit/Source/platform/heap/Visitor.h:35:
In file included from
../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:8:
In file included from
../../third_party/WebKit/Source/platform/heap/ThreadState.h:37:
In file included from
../../third_party/WebKit/Source/platform/heap/ThreadingTraits.h:8:
In file included from ../../third_party/WebKit/Source/wtf/Deque.h:37:
../../third_party/WebKit/Source/wtf/Vector.h:638:9: error: static_assert failed
"Cannot put raw pointers to garbage-collected classes into an off-heap Vector. 
Use HeapVector<Member<T>> instead."
        static_assert(Allocator::isGarbageCollected ||
!IsPointerToGarbageCollectedType<T>::value, "Cannot put raw pointers to
garbage-collected classes into an off-heap Vector.  Use HeapVector<Member<T>>
instead.");
        ^            
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:34:30: note:
in instantiation of member function 'WTF::Vector<blink::HTMLSlotElement *, 0,
WTF::PartitionAllocator>::Vector' requested here
    Vector<HTMLSlotElement*> slots;
                             ^
Can we fix please?

[hayato, 2016-01-06 08:05:41]

On 2016/01/06 07:34:37, noel gordon wrote:
> On 2016/01/06 07:11:51, commit-bot: I haz the power wrote:
> > Patchset 4 (id:??) landed as
> > https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
> > Cr-Commit-Position: refs/heads/master@{#367789}
> 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/b...
> 
> FAILED: /b/build/goma/gomacc
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o.d
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
> -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
> -DCR_CLANG_REVISION=255169-1 ... 
> ../../third_party/WebKit/Source/build/mac/Prefix.h -c
> ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp -o
> obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o
> In file included from
> ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:5:
> In file included from
> ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:8:
> In file included from
../../third_party/WebKit/Source/platform/heap/Handle.h:34:
> In file included from ../../third_party/WebKit/Source/platform/heap/Heap.h:35:
> In file included from
../../third_party/WebKit/Source/platform/heap/GCInfo.h:8:
> In file included from
> ../../third_party/WebKit/Source/platform/heap/Visitor.h:35:
> In file included from
> ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:8:
> In file included from
> ../../third_party/WebKit/Source/platform/heap/ThreadState.h:37:
> In file included from
> ../../third_party/WebKit/Source/platform/heap/ThreadingTraits.h:8:
> In file included from ../../third_party/WebKit/Source/wtf/Deque.h:37:
> ../../third_party/WebKit/Source/wtf/Vector.h:638:9: error: static_assert
failed
> "Cannot put raw pointers to garbage-collected classes into an off-heap Vector.

> Use HeapVector<Member<T>> instead."
>         static_assert(Allocator::isGarbageCollected ||
> !IsPointerToGarbageCollectedType<T>::value, "Cannot put raw pointers to
> garbage-collected classes into an off-heap Vector.  Use HeapVector<Member<T>>
> instead.");
>         ^            
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:34:30:
note:
> in instantiation of member function 'WTF::Vector<blink::HTMLSlotElement *, 0,
> WTF::PartitionAllocator>::Vector' requested here
>     Vector<HTMLSlotElement*> slots;
>                              ^
> Can we fix please?

Let me fix this.

[msramek, 2016-01-06 09:34:39]

On 2016/01/06 08:05:41, hayato wrote:
> On 2016/01/06 07:34:37, noel gordon wrote:
> > On 2016/01/06 07:11:51, commit-bot: I haz the power wrote:
> > > Patchset 4 (id:??) landed as
> > > https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
> > > Cr-Commit-Position: refs/heads/master@{#367789}
> > 
> > 
> >
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/b...
> > 
> > FAILED: /b/build/goma/gomacc
> > ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o.d
> > -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
> > -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
> > -DCR_CLANG_REVISION=255169-1 ... 
> > ../../third_party/WebKit/Source/build/mac/Prefix.h -c
> > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp -o
> > obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o
> > In file included from
> > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:5:
> > In file included from
> > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:8:
> > In file included from
> ../../third_party/WebKit/Source/platform/heap/Handle.h:34:
> > In file included from
../../third_party/WebKit/Source/platform/heap/Heap.h:35:
> > In file included from
> ../../third_party/WebKit/Source/platform/heap/GCInfo.h:8:
> > In file included from
> > ../../third_party/WebKit/Source/platform/heap/Visitor.h:35:
> > In file included from
> > ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:8:
> > In file included from
> > ../../third_party/WebKit/Source/platform/heap/ThreadState.h:37:
> > In file included from
> > ../../third_party/WebKit/Source/platform/heap/ThreadingTraits.h:8:
> > In file included from ../../third_party/WebKit/Source/wtf/Deque.h:37:
> > ../../third_party/WebKit/Source/wtf/Vector.h:638:9: error: static_assert
> failed
> > "Cannot put raw pointers to garbage-collected classes into an off-heap
Vector.
> 
> > Use HeapVector<Member<T>> instead."
> >         static_assert(Allocator::isGarbageCollected ||
> > !IsPointerToGarbageCollectedType<T>::value, "Cannot put raw pointers to
> > garbage-collected classes into an off-heap Vector.  Use
HeapVector<Member<T>>
> > instead.");
> >         ^            
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:34:30:
> note:
> > in instantiation of member function 'WTF::Vector<blink::HTMLSlotElement *,
0,
> > WTF::PartitionAllocator>::Vector' requested here
> >     Vector<HTMLSlotElement*> slots;
> >                              ^
> > Can we fix please?
> 
> Let me fix this.

(Sheriff here:) Are you confident you'll be able to fix this ASAP? Otherwise
I'll revert, as this breaks compilation.

[msramek, 2016-01-06 09:51:05]

On 2016/01/06 09:34:39, msramek wrote:
> On 2016/01/06 08:05:41, hayato wrote:
> > On 2016/01/06 07:34:37, noel gordon wrote:
> > > On 2016/01/06 07:11:51, commit-bot: I haz the power wrote:
> > > > Patchset 4 (id:??) landed as
> > > > https://crrev.com/b7c3414768afff35204a6c6b869c47d90d3953e0
> > > > Cr-Commit-Position: refs/heads/master@{#367789}
> > > 
> > > 
> > >
> >
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/b...
> > > 
> > > FAILED: /b/build/goma/gomacc
> > > ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > >
obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o.d
> > > -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2
> > > -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD
> > > -DCR_CLANG_REVISION=255169-1 ... 
> > > ../../third_party/WebKit/Source/build/mac/Prefix.h -c
> > > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp -o
> > > obj/third_party/WebKit/Source/core/dom/shadow/webcore_dom.SlotAssignment.o
> > > In file included from
> > > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:5:
> > > In file included from
> > > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h:8:
> > > In file included from
> > ../../third_party/WebKit/Source/platform/heap/Handle.h:34:
> > > In file included from
> ../../third_party/WebKit/Source/platform/heap/Heap.h:35:
> > > In file included from
> > ../../third_party/WebKit/Source/platform/heap/GCInfo.h:8:
> > > In file included from
> > > ../../third_party/WebKit/Source/platform/heap/Visitor.h:35:
> > > In file included from
> > > ../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:8:
> > > In file included from
> > > ../../third_party/WebKit/Source/platform/heap/ThreadState.h:37:
> > > In file included from
> > > ../../third_party/WebKit/Source/platform/heap/ThreadingTraits.h:8:
> > > In file included from ../../third_party/WebKit/Source/wtf/Deque.h:37:
> > > ../../third_party/WebKit/Source/wtf/Vector.h:638:9: error: static_assert
> > failed
> > > "Cannot put raw pointers to garbage-collected classes into an off-heap
> Vector.
> > 
> > > Use HeapVector<Member<T>> instead."
> > >         static_assert(Allocator::isGarbageCollected ||
> > > !IsPointerToGarbageCollectedType<T>::value, "Cannot put raw pointers to
> > > garbage-collected classes into an off-heap Vector.  Use
> HeapVector<Member<T>>
> > > instead.");
> > >         ^            
> > >
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > ../../third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp:34:30:
> > note:
> > > in instantiation of member function 'WTF::Vector<blink::HTMLSlotElement *,
> 0,
> > > WTF::PartitionAllocator>::Vector' requested here
> > >     Vector<HTMLSlotElement*> slots;
> > >                              ^
> > > Can we fix please?
> > 
> > Let me fix this.
> 
> (Sheriff here:) Are you confident you'll be able to fix this ASAP? Otherwise
> I'll revert, as this breaks compilation.

...I was just asking in case you're just about to land the fix. Given that
compilation is broken for over 2 hours, I'll revert, sorry.

[msramek, 2016-01-06 09:52:10]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1562743002/ by msramek@chromium.org.

The reason for reverting is: Broken compilation:

FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\third_party\WebKit\Source\core\dom\shadow\webcore_dom.SlotAssignment.obj.rsp
/c ..\..\third_party\WebKit\Source\core\dom\shadow\SlotAssignment.cpp
/Foobj\third_party\WebKit\Source\core\dom\shadow\webcore_dom.SlotAssignment.obj
/Fdobj\third_party\WebKit\Source\core\webcore_dom.cc.pdb 
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\wtf\vector.h(638)
: error C2338: Cannot put raw pointers to garbage-collected classes into an
off-heap Vector.  Use HeapVector<Member<T>> instead.
       
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\wtf\vector.h(632)
: while compiling class template member function
'WTF::Vector<blink::HTMLSlotElement *,0,WTF::PartitionAllocator>::Vector(void)'
       
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\core\dom\shadow\slotassignment.cpp(34)
: see reference to function template instantiation
'WTF::Vector<blink::HTMLSlotElement *,0,WTF::PartitionAllocator>::Vector(void)'
being compiled
       
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\core\dom\shadow\slotassignment.cpp(34)
: see reference to class template instantiation
'WTF::Vector<blink::HTMLSlotElement *,0,WTF::PartitionAllocator>' being compiled
ninja: build stopped: subcommand failed.
.

[hayato, 2016-01-06 10:35:52]

On 2016/01/06 09:52:10, msramek wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1562743002/ by mailto:msramek@chromium.org.
> 
> The reason for reverting is: Broken compilation:
> 
> FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc
> "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
> /showIncludes /FC
>
@obj\third_party\WebKit\Source\core\dom\shadow\webcore_dom.SlotAssignment.obj.rsp
> /c ..\..\third_party\WebKit\Source\core\dom\shadow\SlotAssignment.cpp
>
/Foobj\third_party\WebKit\Source\core\dom\shadow\webcore_dom.SlotAssignment.obj
> /Fdobj\third_party\WebKit\Source\core\webcore_dom.cc.pdb 
>
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\wtf\vector.h(638)
> : error C2338: Cannot put raw pointers to garbage-collected classes into an
> off-heap Vector.  Use HeapVector<Member<T>> instead.
>        
>
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\wtf\vector.h(632)
> : while compiling class template member function
> 'WTF::Vector<blink::HTMLSlotElement
*,0,WTF::PartitionAllocator>::Vector(void)'
>        
>
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\core\dom\shadow\slotassignment.cpp(34)
> : see reference to function template instantiation
> 'WTF::Vector<blink::HTMLSlotElement
*,0,WTF::PartitionAllocator>::Vector(void)'
> being compiled
>        
>
e:\b\build\slave\webkit_win_oilpan\build\src\third_party\webkit\source\core\dom\shadow\slotassignment.cpp(34)
> : see reference to class template instantiation
> 'WTF::Vector<blink::HTMLSlotElement *,0,WTF::PartitionAllocator>' being
compiled
> ninja: build stopped: subcommand failed.
> .

Sorry for the lack of the explanation. I should have mentioned that I can fix
this at prompt.
The fix was landed: https://codereview.chromium.org/1562013002/. I should have
used NOTRY= there. My bad.