Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1530553002: Revert of Enable Control Flow Integrity for the official Linux Chrome. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #3 id:40001 of https://codereview.chromium.org/1513623004/ ) Reason for revert: Link time for the official Chrome on the perf buildbot is more than 1 hour. Possibly, some regression in LLVM Gold plugin. Original issue's description: > Enable Control Flow Integrity for the official Linux Chrome. > > This CL turns on CFI, a security check: > https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity > http://clang.llvm.org/docs/ControlFlowIntegrity.html > > This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. > CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, > and should not be an issue. > > BUG=chromium:464797 > Intent to Implement thread: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ > > This is a fifth attempt to land the CL. Previous attempts: > https://codereview.chromium.org/1502373003/ > https://codereview.chromium.org/1501593003/ > https://codereview.chromium.org/1393283005/ > https://codereview.chromium.org/1502233004/ > > The last time it failed, it was primarily due to the new Clang roll, > that had a bug in the linker. This is now fixed upstream and > the new Clang roll happened: https://crbug.com/568248 > > Perf bots were purple and got a RAM upgrade: https://crbug.com/567787 > > precice64 official buildbot got OOM due to too many Gold instances > running in parallel: https://crbug.com/568011, a more conservative > limit was submitted: https://codereview.chromium.org/1509733004/ > > TBR=thestig@chromium.org > > Committed: https://crrev.com/efe55ae0c0f26165d71d540ac319ccc9bc569cb3 > Cr-Commit-Position: refs/heads/master@{#365117} TBR=thakis@chromium.org,thestig@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:464797 Committed: https://crrev.com/e24db69d101447028c9ea6008a023865a9ca3af9 Cr-Commit-Position: refs/heads/master@{#365133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
krasin
Created Revert of Enable Control Flow Integrity for the official Linux Chrome.
5 years ago (2015-12-15 01:03:52 UTC) #1
pcc1
lgtm
5 years ago (2015-12-15 01:07:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530553002/1
5 years ago (2015-12-15 01:12:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 01:16:48 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-15 01:17:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e24db69d101447028c9ea6008a023865a9ca3af9
Cr-Commit-Position: refs/heads/master@{#365133}

Powered by Google App Engine
This is Rietveld 408576698