Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1509733004: Give more RAM per ld process. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give more RAM per ld process. It has been observed that occasionally official buildbots would crash with OOM, when building Chrome with CFI (and thus with LTO). This CL reduces the number of concurrent link processes to avoid this problem. BUG=464797 Committed: https://crrev.com/2d29f7386050b401838cfbb722a0f53fd1230fce Cr-Commit-Position: refs/heads/master@{#364173}

Patch Set 1 #

Patch Set 2 : reserve 20 GB for spikes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/toolchain/get_concurrent_links.py View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
krasin
5 years ago (2015-12-09 04:31:33 UTC) #2
krasin
5 years ago (2015-12-09 04:32:05 UTC) #3
krasin
5 years ago (2015-12-09 04:32:06 UTC) #4
Nico
This only controls how many ld processes ninja will allow to run in parallel at ...
5 years ago (2015-12-09 15:53:36 UTC) #5
imkrasin
On 2015/12/09 15:53:36, Nico wrote: > This only controls how many ld processes ninja will ...
5 years ago (2015-12-09 16:53:10 UTC) #6
krasin
Nico, please, take another look. I have decided to be even more conservative and make ...
5 years ago (2015-12-09 21:24:55 UTC) #7
Nico
lgtm
5 years ago (2015-12-09 21:28:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1509733004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1509733004/20001
5 years ago (2015-12-09 21:46:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 22:15:10 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-09 22:16:52 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d29f7386050b401838cfbb722a0f53fd1230fce
Cr-Commit-Position: refs/heads/master@{#364173}

Powered by Google App Engine
This is Rietveld 408576698