Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1530523002: More cleanups in JingleSessionManager interface. (Closed)

Created:
5 years ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@transport_context
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More cleanups in JingleSessionManager interface. 1. Removed Close() method. 2. Replaced Init() method with AcceptIncoming() that's called only on the host. Committed: https://crrev.com/1b03268d85cb1563eeec00bc44cb612f418b2839 Cr-Commit-Position: refs/heads/master@{#365702}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -165 lines) Patch
M remoting/host/chromoting_host.h View 3 chunks +3 lines, -9 lines 0 comments Download
M remoting/host/chromoting_host.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 13 chunks +22 lines, -37 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/protocol/connection_to_host_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M remoting/protocol/connection_to_host_impl.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M remoting/protocol/jingle_session_manager.h View 2 chunks +10 lines, -12 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 3 chunks +15 lines, -26 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/session_manager.h View 1 4 chunks +18 lines, -36 lines 0 comments Download
M remoting/test/protocol_perftest.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Sergey Ulanov
5 years ago (2015-12-15 00:15:12 UTC) #2
Jamie
lgtm https://codereview.chromium.org/1530523002/diff/1/remoting/protocol/jingle_session_manager.cc File remoting/protocol/jingle_session_manager.cc (right): https://codereview.chromium.org/1530523002/diff/1/remoting/protocol/jingle_session_manager.cc#newcode40 remoting/protocol/jingle_session_manager.cc:40: incoming_session_callback_ = incoming_session_callback; DCHECK(incoming_session_callback_.is_null())? Or is it acceptable ...
5 years ago (2015-12-15 00:32:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530523002/20001
5 years ago (2015-12-16 23:13:47 UTC) #6
Sergey Ulanov
https://codereview.chromium.org/1530523002/diff/1/remoting/protocol/jingle_session_manager.cc File remoting/protocol/jingle_session_manager.cc (right): https://codereview.chromium.org/1530523002/diff/1/remoting/protocol/jingle_session_manager.cc#newcode40 remoting/protocol/jingle_session_manager.cc:40: incoming_session_callback_ = incoming_session_callback; On 2015/12/15 00:32:01, Jamie wrote: > ...
5 years ago (2015-12-16 23:17:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 03:17:54 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 03:18:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b03268d85cb1563eeec00bc44cb612f418b2839
Cr-Commit-Position: refs/heads/master@{#365702}

Powered by Google App Engine
This is Rietveld 408576698