Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530503003: Return error on Get(*Key). (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Return error on Get(*Key). Before it would end up returning ErrInvalidKey, which is silly :). R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org, martiniss@chromium.org BUG=https://github.com/luci/gae/issues/27 Committed: https://github.com/luci/gae/commit/fc08da0d2a5b8f80706e04b817b1573301479260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M service/datastore/datastore.go View 1 chunk +3 lines, -0 lines 0 comments Download
M service/datastore/datastore_test.go View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iannucci
5 years ago (2015-12-14 23:26:03 UTC) #1
martiniss
lgtm yay error messages are fun!
5 years ago (2015-12-14 23:28:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530503003/1
5 years ago (2015-12-14 23:33:20 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-14 23:36:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/fc08da0d2a5b8f80706e04b817b1573301479260

Powered by Google App Engine
This is Rietveld 408576698