service/datastore/datastore.go - Issue 1530503003: Return error on Get(*Key).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/datastore.go

Issue 1530503003: Return error on Get(*Key). (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/datastore.go

diff --git a/service/datastore/datastore.go b/service/datastore/datastore.go

index 3b05f392b8b336ec7e1df474475641be8f881b12..fc37d5a2356627066d9c12e122ce46eacccc49c3 100644

--- a/service/datastore/datastore.go

+++ b/service/datastore/datastore.go

@@ -219,6 +219,9 @@ func (d *datastoreImpl) GetAll(q *Query, dst interface{}) error {

}

func isOkType(v reflect.Type) bool {

+ if v == typeOfKey {

+ return false

+ }

if v.Implements(typeOfPropertyLoadSaver) {

return true

}

« no previous file with comments | « no previous file | service/datastore/datastore_test.go » ('j') | no next file with comments »