Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530443005: EDK: Add PlatformHandleWatcher to Channel (and ChannelManager) classes. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add PlatformHandleWatcher to Channel (and ChannelManager) classes. Almost there! R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/af46d4238e3b0bdd5a74f68e1dad5e029e903d26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -39 lines) Patch
M mojo/edk/system/channel.h View 3 chunks +17 lines, -14 lines 0 comments Download
M mojo/edk/system/channel.cc View 3 chunks +7 lines, -1 line 0 comments Download
M mojo/edk/system/channel_manager.h View 4 chunks +14 lines, -7 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M mojo/edk/system/channel_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/system/ipc_support.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1526063003 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-15 18:12:03 UTC) #1
vardhan
lgtm
5 years ago (2015-12-15 19:20:51 UTC) #2
viettrungluu
5 years ago (2015-12-15 20:35:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
af46d4238e3b0bdd5a74f68e1dad5e029e903d26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698