Issue 1526063003: EDK: Add TaskRunner and PlatformHandleWatcher to RawChannel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1526063003: EDK: Add TaskRunner and PlatformHandleWatcher to RawChannel. (Closed)

Created:
5 years ago by viettrungluu

Modified:
5 years ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@channel_watcher

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Add TaskRunner and PlatformHandleWatcher to RawChannel. Still need to convert RawChannelPosix. So much yak, so little time. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7b73f3a9303203aa33e220a874477790a0255325

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+106 lines, -39 lines)			Patch
M	mojo/edk/system/channel.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.cc	View	6 chunks	+12 lines, -8 lines	0 comments	Download
M	mojo/edk/system/raw_channel.h	View	3 chunks	+9 lines, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel.cc	View	3 chunks	+14 lines, -3 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View	13 chunks	+60 lines, -19 lines	0 comments	Download
M	mojo/edk/system/slave_connection_manager.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	mojo/edk/system/slave_connection_manager.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download

Depends on Patchset:

Issue 1530443005 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

5 years ago (2015-12-15 20:36:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7b73f3a9303203aa33e220a874477790a0255325 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages