Autofilling passwords imported from IE more conservative

Autofilling passwords imported from IE more conservative

The trick is to leave action, username_element and password_element
fields of the form empty, this will stop the browser from autofilling
every form on the page with the credentials and will require user
interaction.
The user will have to click on the input box, select his login from
the drop down and click 'submit'. When this happens, Login Data will
be updated with the action url of the particular form.

Basically, since we don't know which form on the page is the one we 
have imported credentials for, we don't autofill anything until the 
user tells us. We'll remember his choice afterwards.

BUG=52513
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251035

[mpawlowski, 2014-02-06 10:28:43]

Fixing a 3 year old bug ;)

[jeremy, 2014-02-06 11:50:20]

Sorry, I only did work on the Mac importers :(
From looking at the blamelist for this file I think Scott is your best bet at a
reviewer for this...

Is this covered by any kind of unit test?

[mpawlowski, 2014-02-06 13:33:04]

On 2014/02/06 11:50:20, jeremy wrote:
> Sorry, I only did work on the Mac importers :(
> From looking at the blamelist for this file I think Scott is your best bet at
a
> reviewer for this...

Is 'sky' him?

> Is this covered by any kind of unit test?

Nope, I changed this bit and no unit test failed. There are very few enabled
unit tests for password_store_win.

[sky, 2014-02-06 17:42:23]

I'm not familiar with this code sky->thestig (he reviewed your last change to
this file.

[Lei Zhang, 2014-02-07 02:34:53]

+ an autofill owner

[Garrett Casto, 2014-02-11 00:08:42]

Change looks reasonable, though would you mind updating the ConvertIE7Login test
as part of this? If it weren't disabled, it looks like it would now fail. This
code has been unowned for a very long period of time so hopefully we will get
around to re-enabling tests like this soon.

[mpawlowski, 2014-02-11 14:10:17]

On 2014/02/11 00:08:42, Garrett Casto wrote:
> Change looks reasonable, though would you mind updating the ConvertIE7Login
test
> as part of this? If it weren't disabled, it looks like it would now fail.

Good catch, it indeed failed. Fixed it.

[Garrett Casto, 2014-02-13 00:11:21]

LGTM

[mpawlowski, 2014-02-13 08:05:27]

The CQ bit was checked by mpawlowski@opera.com

[commit-bot: I haz the power, 2014-02-13 08:06:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpawlowski@opera.com/153043005/100001

[commit-bot: I haz the power, 2014-02-13 09:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 09:05:49]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[mpawlowski, 2014-02-13 12:11:09]

The CQ bit was checked by mpawlowski@opera.com

[commit-bot: I haz the power, 2014-02-13 12:11:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpawlowski@opera.com/153043005/100001

[commit-bot: I haz the power, 2014-02-13 15:56:58]

Change committed as 251035