Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: chrome/browser/password_manager/password_store_win_unittest.cc

Issue 153043005: Autofilling passwords imported from IE more conservative (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updating unit test" Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/password_store_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_store_win_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_win_unittest.cc b/chrome/browser/password_manager/password_store_win_unittest.cc
index 82ab79b862dfcf7b27f8ff1dc5d9ecf65a34923b..a99586c07e532034c396832df28383a42999ec94 100644
--- a/chrome/browser/password_manager/password_store_win_unittest.cc
+++ b/chrome/browser/password_manager/password_store_win_unittest.cc
@@ -220,14 +220,16 @@ TEST_F(PasswordStoreWinTest, DISABLED_ConvertIE7Login) {
};
scoped_ptr<PasswordForm> form(CreatePasswordFormFromData(form_data));
+ // The returned form will not have 'action' or '*_element' fields set. This
+ // is because credentials imported from IE don't have this information.
PasswordFormData expected_form_data = {
PasswordForm::SCHEME_HTML,
"http://example.com/",
"http://example.com/origin",
- "http://example.com/action",
- L"submit_element",
- L"username_element",
- L"password_element",
+ "",
+ L"",
+ L"",
+ L"",
L"abcdefgh",
L"abcdefghijkl",
true, false, 1,
« no previous file with comments | « chrome/browser/password_manager/password_store_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698