Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/feedback/feedback_common.h

Issue 1530403003: Add anonymizer tool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feedback/feedback_common.h
diff --git a/components/feedback/feedback_common.h b/components/feedback/feedback_common.h
index a95301d5c60d45aaafcc9a34f08751d7305c707b..1b3e65819b59c51fb2c5c51fd63a4735a20cae05 100644
--- a/components/feedback/feedback_common.h
+++ b/components/feedback/feedback_common.h
@@ -48,8 +48,11 @@ class FeedbackCommon : public base::RefCountedThreadSafe<FeedbackCommon> {
void CompressFile(const base::FilePath& filename,
const std::string& zipname,
scoped_ptr<std::string> data);
+ // File attachments are not anonymized. It is the responsibility of the caller
+ // to remove personally identifying information by using the AnonymizerTool.
void AddFile(const std::string& filename, scoped_ptr<std::string> data);
+ // Logs are anonymized via the AnonymizerTool.
void AddLog(const std::string& name, const std::string& value);
void AddLogs(scoped_ptr<SystemLogsMap> logs);
void CompressLogs();
@@ -59,6 +62,8 @@ class FeedbackCommon : public base::RefCountedThreadSafe<FeedbackCommon> {
// Fill in |feedback_data| with all the data that we have collected.
// CompressLogs() must have already been called.
+ // File attachments in the feedback data need to be properly anonymized before
vasilii 2015/12/17 12:40:37 The comment above says that the file attachments a
battre 2015/12/17 13:24:24 I don't understand. Neither AddFile nor PrepareRep
+ // reporting using the AnonymizerTool.
void PrepareReport(userfeedback::ExtensionSubmit* feedback_data) const;
// Getters

Powered by Google App Engine
This is Rietveld 408576698