Add anonymizer tool

components/feedback/feedback_common.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_
 #define COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_
 
 #include <map>
 #include <string>
 
@@ skipping 30 matching lines @@
 
   // Determine if the given feedback value is small enough to not need to
   // be compressed.
   static bool BelowCompressionThreshold(const std::string& content);
 
   FeedbackCommon();
 
   void CompressFile(const base::FilePath& filename,
                     const std::string& zipname,
                     scoped_ptr<std::string> data);
+  // File attachments are not anonymized. It is the responsibility of the caller
+  // to remove personally identifying information by using the AnonymizerTool.
   void AddFile(const std::string& filename, scoped_ptr<std::string> data);
 
+  // Logs are anonymized via the AnonymizerTool.
   void AddLog(const std::string& name, const std::string& value);
   void AddLogs(scoped_ptr<SystemLogsMap> logs);
   void CompressLogs();
 
   void AddFilesAndLogsToReport(
       userfeedback::ExtensionSubmit* feedback_data) const;
 
   // Fill in |feedback_data| with all the data that we have collected.
   // CompressLogs() must have already been called.
+  // File attachments in the feedback data need to be properly anonymized before

[vasilii, 2015/12/17 12:40:37]

The comment above says that the file attachments aren't anonymised.

[battre, 2015/12/17 13:24:24]

I don't understand. Neither AddFile nor PrepareReport takes care of anonymizing
file attachments. This needs to be done be the caller.

+  // reporting using the AnonymizerTool.
   void PrepareReport(userfeedback::ExtensionSubmit* feedback_data) const;
 
   // Getters
   const std::string& category_tag() const { return category_tag_; }
   const std::string& page_url() const { return page_url_; }
   const std::string& description() const { return description_; }
   const std::string& user_email() const { return user_email_; }
   const std::string* image() const { return image_.get(); }
   const SystemLogsMap* sys_info() const { return logs_.get(); }
   int32_t product_id() const { return product_id_; }
@@ skipping 40 matching lines @@
 
   // It is possible that multiple attachment add calls are running in
   // parallel, so synchronize access.
   base::Lock attachments_lock_;
   ScopedVector<AttachedFile> attachments_;
 
   scoped_ptr<SystemLogsMap> logs_;
 };
 
 #endif  // COMPONENTS_FEEDBACK_FEEDBACK_COMMON_H_