pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart - Issue 1530393004: suggest IDENTIFIER not INVOCATION for dartdoc refs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

Issue 1530393004: suggest IDENTIFIER not INVOCATION for dartdoc refs (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/optype.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

index 9d14fda53cbe1282b455ed2792de43cae6de7561..1002765ddb635c5990a5892601786bc9e03e099a 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart

@@ -306,7 +306,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {

int relevance: DART_RELEVANCE_DEFAULT}) {

CompletionSuggestionKind kind = targetIsFunctionalArgument

? CompletionSuggestionKind.IDENTIFIER

- : CompletionSuggestionKind.INVOCATION;

+ : optype.suggestKind;

CompletionSuggestion suggestion = _createLocalSuggestion(

id, kind, isDeprecated, relevance, typeName,

classDecl: classDecl);