pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart - Issue 1530393004: suggest IDENTIFIER not INVOCATION for dartdoc refs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

Issue 1530393004: suggest IDENTIFIER not INVOCATION for dartdoc refs (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

index e0f470534211deb7979c2a8ec487588914b5a332..02878a08085c4c7f7e1b62dd1ad8574f044ac895 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart

@@ -70,7 +70,7 @@ class LibraryElementSuggestionBuilder extends GeneralizingElementVisitor

LibraryElementSuggestionBuilder(this.request, this.optype, [this.prefix]) {

this.kind = request.target.isFunctionalArgument()

? CompletionSuggestionKind.IDENTIFIER

- : CompletionSuggestionKind.INVOCATION;

+ : optype.suggestKind;

}

@override

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart » ('j') | no next file with comments »