Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1530303003: Implement Layout Containment (Closed)

Created:
5 years ago by leviw_travelin_and_unemployed
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Layout Containment Layout containment provides a guarantee that an element's subtree will not escape its bounds in a layout-impactful way. This means that the element's descendants don't impact its size, so it collapses away when the size isn't specified. It also creates a formatting context. Layout Containment description from spec: https://drafts.csswg.org/css-containment/#containment-layout Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9W80Kw-z3ss BUG=561713 Committed: https://crrev.com/b66c49fa179e76970cc9cf4500fee1f9f0ff2cb8 Cr-Commit-Position: refs/heads/master@{#378906}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add additional test case and descriptions #

Total comments: 3

Patch Set 3 : Address Ojan's first comment #

Patch Set 4 : ToT-ed #

Patch Set 5 : Switch to Ahem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing-expected.txt View 1 2 3 4 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 3 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
leviw_travelin_and_unemployed
5 years ago (2015-12-16 22:20:15 UTC) #2
szager1
https://codereview.chromium.org/1530303003/diff/1/third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html File third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html (right): https://codereview.chromium.org/1530303003/diff/1/third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html#newcode44 third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html:44: <div id="absolute"> Might be a good idea to do ...
5 years ago (2015-12-16 23:46:23 UTC) #3
leviw_travelin_and_unemployed
On 2015/12/16 at 23:46:23, szager wrote: > https://codereview.chromium.org/1530303003/diff/1/third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html > File third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html (right): > > https://codereview.chromium.org/1530303003/diff/1/third_party/WebKit/LayoutTests/fast/css/containment/layout-containment-sizing.html#newcode44 ...
5 years ago (2015-12-17 00:04:35 UTC) #4
szager1
lgtm
5 years ago (2015-12-18 17:20:09 UTC) #5
ojan
lgtm https://codereview.chromium.org/1530303003/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1530303003/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode2248 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:2248: if ((!style()->isOverflowVisible() && !shouldIgnoreOverflowPropertyForInlineBlockBaseline()) || style()->containsLayout()) { I ...
5 years ago (2015-12-18 18:21:14 UTC) #6
leviw_travelin_and_unemployed
Tab, ptal at the comment regarding baselines for inline-blocks with contain: layout. https://codereview.chromium.org/1530303003/diff/20001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp ...
4 years, 11 months ago (2016-01-12 19:36:31 UTC) #8
esprehn
I think you need to ping tab directly, he's bad at @chromium.org emails.
4 years, 10 months ago (2016-02-10 10:23:16 UTC) #9
leviw_travelin_and_unemployed
On 2016/02/10 at 10:23:16, esprehn wrote: > I think you need to ping tab directly, ...
4 years, 10 months ago (2016-02-12 02:20:57 UTC) #10
leviw_travelin_and_unemployed
I chatted with Tab. On the baseline issue: "Yes, I agree. I'll specify that." We ...
4 years, 9 months ago (2016-03-02 23:35:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530303003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530303003/80001
4 years, 9 months ago (2016-03-02 23:35:31 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-03 01:30:22 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 01:31:51 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b66c49fa179e76970cc9cf4500fee1f9f0ff2cb8
Cr-Commit-Position: refs/heads/master@{#378906}

Powered by Google App Engine
This is Rietveld 408576698