Chromium Code Reviews
Help | Chromium Project | Sign in
(669)

Issue 15303003: UI Updates for OSX App Launcher: truncate titles, window shadow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 1 week ago by tapted
Modified:
11 months, 1 week ago
Reviewers:
koz
CC:
chromium-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, sail+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

UI Updates for OSX App Launcher: truncate titles, window shadow.

Truncate titles on button labels, replacing the end of long titles with
with the ellipsis glyph.

Also, restore the default OS window shadow for now.

BUG=138633
TEST=Show some apps with long titles in the app launcher, they should
end with an ellipsis rather than getting cut off.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201049

Patch Set 1 #

Patch Set 2 : need to set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Lint Patch
M ui/app_list/cocoa/app_list_window_controller.mm View 1 1 chunk +1 line, -1 line 0 comments ? errors Download
M ui/app_list/cocoa/apps_grid_view_item.mm View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 6
tapted
koz, could you take a look at this one?
11 months, 1 week ago #1
koz
lgtm
11 months, 1 week ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/15303003/2002
11 months, 1 week ago #3
I haz the power (commit-bot)
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150843
11 months, 1 week ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/15303003/2002
11 months, 1 week ago #5
I haz the power (commit-bot)
11 months, 1 week ago #6
Message was sent while issue was closed.
Change committed as 201049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6