Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530213002: Make generators non-constructable (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
4 years, 11 months ago
Reviewers:
neis, adamk, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make generators non-constructable BUG=v8:4163 LOG=y

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove broken tests #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/es6/generators-iteration.js View 1 2 2 chunks +3 lines, -26 lines 2 comments Download
M test/mjsunit/es6/generators-objects.js View 2 chunks +4 lines, -4 lines 1 comment Download
M test/mjsunit/es6/object-literals-method.js View 1 chunk +2 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
5 years ago (2015-12-17 12:16:59 UTC) #2
adamk
Attached the bug for this to the description. Code looks good, but I think we ...
5 years ago (2015-12-17 13:24:34 UTC) #4
Toon Verwaest
4 years, 11 months ago (2016-01-14 09:58:52 UTC) #6
neis
Some minor comments concerning tests. https://codereview.chromium.org/1530213002/diff/40001/test/mjsunit/es6/generators-iteration.js File test/mjsunit/es6/generators-iteration.js (left): https://codereview.chromium.org/1530213002/diff/40001/test/mjsunit/es6/generators-iteration.js#oldcode251 test/mjsunit/es6/generators-iteration.js:251: TestGenerator( This one should ...
4 years, 11 months ago (2016-01-14 10:55:24 UTC) #7
neis
4 years, 11 months ago (2016-01-14 11:33:52 UTC) #8 
Also note that set_is_constructor no longer lets you unset the bit, so you may
need to start from a different map or undo Benedikt's change to
set_is_constructor.

Powered by Google App Engine
This is Rietveld 408576698