src/globals.h - Issue 1530213002: Make generators non-constructable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 1530213002: Make generators non-constructable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove broken tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 67bdb63b86ee7a008e1fe0eebaab710c6d0eec60..c6a5444d8ac94fa2d29cefa2a5350b6033a27f51 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -1024,8 +1024,9 @@ inline bool IsClassConstructor(FunctionKind kind) {

inline bool IsConstructable(FunctionKind kind, LanguageMode mode) {

if (IsAccessorFunction(kind)) return false;

- if (IsConciseMethod(kind) && !IsGeneratorFunction(kind)) return false;

+ if (IsConciseMethod(kind)) return false;

if (IsArrowFunction(kind)) return false;

+ if (IsGeneratorFunction(kind)) return false;

if (is_strong(mode)) return IsClassConstructor(kind);

return true;

}