Issue 15302015: Remove the enrollment dialog extra border.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15302015: Remove the enrollment dialog extra border. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pneubeck (no reviews), Greg Spencer (Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the enrollment dialog extra border. EnrollmentDialogView uses Widget::CreateWindowWithParent. Use DialogDelegate::CreateDialogWidget instead. Does not change the old-style appearance or behavior. See before/after pics at http://crbug.com/166075#c83 I triggered the dialog with debug code in Patch Set 1. (try to join a network with the debugging code in place) BUG=166075 TEST=new-style enrollment dialog does not have an extra border. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201027

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/enrollment_dialog_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15302015/2001

7 years, 7 months ago (2013-05-18 04:03:25 UTC) #2

Message was sent while issue was closed.

Change committed as 201027

Expand Messages | Collapse Messages