Convert ToBooleanStub to a HydrogenStub. Currently just using HBranch, which is still fully impleme…

Convert ToBooleanStub to a HydrogenStub. Currently just using the existing HBranch instruction, which is still fully implemented in Lithium. Will refactor HBranch in a next CL.

[
CL breaks mips, since the deoptimizer in Deoptimizer::DoTranslateCommand(...) does not convert smis passed to the stub via a0.
]

BUG=
R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14886

[Toon Verwaest, 2013-05-28 09:33:32]

first set of comments.

https://codereview.chromium.org/15302004/diff/18004/src/checks.h
File src/checks.h (right):

https://codereview.chromium.org/15302004/diff/18004/src/checks.h#newcode278
src/checks.h:278: #define FOR_ASSERT(statement)  ((void) 0)
What about just putting the statement in #ifdef DEBUG?

https://codereview.chromium.org/15302004/diff/18004/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/15302004/diff/18004/src/code-stubs-hydrogen.c...
src/code-stubs-hydrogen.cc:691: return graph()->GetConstantUndefined();
This is a bit weird. What about just having the Then branch in the if_true; and
returning graph()->GetConstant0() rather than GetConstantUndefined() after the
iftrue?

https://codereview.chromium.org/15302004/diff/18004/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/15302004/diff/18004/src/code-stubs.h#newcode675
src/code-stubs.h:675: enum ExponentType { INTEGER, DOUBLE, TAGGED, ON_STACK};
Restore the space.

https://codereview.chromium.org/15302004/diff/18004/src/ia32/lithium-codegen-...
File src/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/15302004/diff/18004/src/ia32/lithium-codegen-...
src/ia32/lithium-codegen-ia32.cc:2251: ASSERT(info()->IsStub() ?
considered_typefeedback : true);
Just move the ASSERT(!info()->IsStub()) to all other branches.

https://codereview.chromium.org/15302004/diff/18004/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/15302004/diff/18004/src/ic.cc#newcode2980
src/ic.cc:2980: patch(*code);
Just directly use set_target and remove patch.

[oliv, 2013-05-28 12:09:26]

On 2013/05/28 09:33:32, Toon Verwaest wrote:
> first set of comments.
> 
> https://codereview.chromium.org/15302004/diff/18004/src/checks.h
> File src/checks.h (right):
> 
> https://codereview.chromium.org/15302004/diff/18004/src/checks.h#newcode278
> src/checks.h:278: #define FOR_ASSERT(statement)  ((void) 0)
> What about just putting the statement in #ifdef DEBUG?
> 
> https://codereview.chromium.org/15302004/diff/18004/src/code-stubs-hydrogen.cc
> File src/code-stubs-hydrogen.cc (right):
> 
>
https://codereview.chromium.org/15302004/diff/18004/src/code-stubs-hydrogen.c...
> src/code-stubs-hydrogen.cc:691: return graph()->GetConstantUndefined();
> This is a bit weird. What about just having the Then branch in the if_true;
and
> returning graph()->GetConstant0() rather than GetConstantUndefined() after the
> iftrue?
> 
> https://codereview.chromium.org/15302004/diff/18004/src/code-stubs.h
> File src/code-stubs.h (right):
> 
>
https://codereview.chromium.org/15302004/diff/18004/src/code-stubs.h#newcode675
> src/code-stubs.h:675: enum ExponentType { INTEGER, DOUBLE, TAGGED, ON_STACK};
> Restore the space.
> 
>
https://codereview.chromium.org/15302004/diff/18004/src/ia32/lithium-codegen-...
> File src/ia32/lithium-codegen-ia32.cc (right):
> 
>
https://codereview.chromium.org/15302004/diff/18004/src/ia32/lithium-codegen-...
> src/ia32/lithium-codegen-ia32.cc:2251: ASSERT(info()->IsStub() ?
> considered_typefeedback : true);
> Just move the ASSERT(!info()->IsStub()) to all other branches.
> 
> https://codereview.chromium.org/15302004/diff/18004/src/ic.cc
> File src/ic.cc (right):
> 
> https://codereview.chromium.org/15302004/diff/18004/src/ic.cc#newcode2980
> src/ic.cc:2980: patch(*code);
> Just directly use set_target and remove patch.

ok

[Toon Verwaest, 2013-05-28 12:40:36]

lgtm

[oliv, 2013-05-29 14:49:43]

Committed patchset #3 manually as r14886 (presubmit successful).