Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 15302004: Convert ToBooleanStub to a HydrogenStub. Currently just using HBranch, which is still fully impleme… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 658 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 return continuation.IsTrueReachable() 669 return continuation.IsTrueReachable()
670 ? graph()->GetConstant1() 670 ? graph()->GetConstant1()
671 : graph()->GetConstantUndefined(); 671 : graph()->GetConstantUndefined();
672 } 672 }
673 673
674 674
675 Handle<Code> CompareNilICStub::GenerateCode() { 675 Handle<Code> CompareNilICStub::GenerateCode() {
676 return DoGenerateCode(this); 676 return DoGenerateCode(this);
677 } 677 }
678 678
679
680 template <>
681 HValue* CodeStubGraphBuilder<ToBooleanStub>::BuildCodeInitializedStub() {
682 ToBooleanStub* stub = casted_stub();
683
684 IfBuilder if_true(this);
685 if_true.If<HBranch>(GetParameter(0), stub->GetTypes());
686 if_true.Then();
687 if_true.Return(graph()->GetConstant1());
688 if_true.Else();
689 if_true.Return(graph()->GetConstant0());
690 if_true.End();
691 return graph()->GetConstantUndefined();
Toon Verwaest 2013/05/28 09:33:32 This is a bit weird. What about just having the Th
692 }
693
694
695 Handle<Code> ToBooleanStub::GenerateCode() {
696 return DoGenerateCode(this);
697 }
698
699
679 } } // namespace v8::internal 700 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698