Refactor VariationsHttpHeaderProvider.

Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org

Committed: https://crrev.com/9a2798399231b89c9becb3c9ca016da34550ebd2
Cr-Commit-Position: refs/heads/master@{#365991}

[Alexei Svitkine (slow), 2015-12-17 20:43:36]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:43:42]

Patchset #2 (id:40001) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:43:46]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:44:02]

Patchset #1 (id:60001) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:45:37]

Description was changed from

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to
the main variations component, so that it can be used
by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still
needs to depend on net, which uses the http header
provider internally. Updates callers of the previous
API to use the new simpler API that doesn't require
going through the singleton by clients.

BUG=530223
==========

to

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

BUG=530223
==========

[Alexei Svitkine (slow), 2015-12-17 20:54:25]

Patchset #1 (id:80001) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:58:21]

Patchset #1 (id:100001) has been deleted

[Alexei Svitkine (slow), 2015-12-17 20:58:57]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org

[Alexei Svitkine (slow), 2015-12-17 20:58:58]

jwd: PTAL

Planning to TBR downstream owners of calling code for the API updates.

[jwd, 2015-12-17 22:04:16]

lgtm

[Alexei Svitkine (slow), 2015-12-17 22:08:08]

Description was changed from

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

BUG=530223
==========

to

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
==========

[Alexei Svitkine (slow), 2015-12-17 22:09:22]

Description was changed from

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
==========

to

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org
==========

[Alexei Svitkine (slow), 2015-12-17 22:09:22]

asvitkine@chromium.org changed reviewers:
+ caitkp@chromium.org, thestig@chromium.org

[Alexei Svitkine (slow), 2015-12-17 22:11:07]

+TBR owners for updates to an API that requires updating callers
+caitkp@ for components/
+thestig@ for chrome/

[Alexei Svitkine (slow), 2015-12-17 22:11:19]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-12-17 22:12:26]

Note: components/variations and components/metrics are not being TBRd and have
been reviewed by jwd@

[commit-bot: I haz the power, 2015-12-17 22:13:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530133005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530133005/160001

[Lei Zhang, 2015-12-17 23:33:23]

lgtm

[commit-bot: I haz the power, 2015-12-18 00:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 00:27:41]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2015-12-18 01:34:32]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-12-18 01:36:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530133005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530133005/160001

[commit-bot: I haz the power, 2015-12-18 02:35:57]

Description was changed from

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org
==========

to

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org
==========

[commit-bot: I haz the power, 2015-12-18 02:35:58]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2015-12-18 02:36:55]

Description was changed from

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org
==========

to

==========
Refactor VariationsHttpHeaderProvider.

The goal is to move the bulk of its implementation to the main
variations component, so that it can be used by this CL from JNI:
https://codereview.chromium.org/1528543003/

Creates variations_http_headers.cc in net that still needs to depend
on net, which uses the http header provider internally. Updates
callers of the previous API to use the new simpler API that doesn't
require going through the singleton by clients.

Additionally, also adds variations/synthetic_trials.h and moves
the synthetic trials structs from metrics_service.h to the new
file. This works around an otherwise circular dependency between
metrics and variations, since variations_http_header_provider.cc
depends on synthetic trials.

TBRs below are for owners of downstream users of the API which
is being updated.

BUG=530223
TBR=caitkp@chromium.org,thestig@chromium.org

Committed: https://crrev.com/9a2798399231b89c9becb3c9ca016da34550ebd2
Cr-Commit-Position: refs/heads/master@{#365991}
==========

[commit-bot: I haz the power, 2015-12-18 02:36:56]

Patchset 3 (id:??) landed as
https://crrev.com/9a2798399231b89c9becb3c9ca016da34550ebd2
Cr-Commit-Position: refs/heads/master@{#365991}