Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/metrics/metrics_service_unittest.cc

Issue 1530133005: Refactor VariationsHttpHeaderProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing include to srt_fetcher_win.cc. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/metrics_service_accessor.cc ('k') | components/omnibox.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_service_unittest.cc
diff --git a/components/metrics/metrics_service_unittest.cc b/components/metrics/metrics_service_unittest.cc
index b306c9b7523c3e36d4b84cb8586cd9d841331ccf..e3de5aebda0a6a2556c9b5942fa5cd3b67679c42 100644
--- a/components/metrics/metrics_service_unittest.cc
+++ b/components/metrics/metrics_service_unittest.cc
@@ -315,10 +315,12 @@ TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {
MetricsService service(GetMetricsStateManager(), &client, GetLocalState());
// Add two synthetic trials and confirm that they show up in the list.
- SyntheticTrialGroup trial1(HashName("TestTrial1"), HashName("Group1"));
+ variations::SyntheticTrialGroup trial1(HashName("TestTrial1"),
+ HashName("Group1"));
service.RegisterSyntheticFieldTrial(trial1);
- SyntheticTrialGroup trial2(HashName("TestTrial2"), HashName("Group2"));
+ variations::SyntheticTrialGroup trial2(HashName("TestTrial2"),
+ HashName("Group2"));
service.RegisterSyntheticFieldTrial(trial2);
// Ensure that time has advanced by at least a tick before proceeding.
WaitUntilTimeChanges(base::TimeTicks::Now());
@@ -345,14 +347,16 @@ TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {
WaitUntilTimeChanges(begin_log_time);
// Change the group for the first trial after the log started.
- SyntheticTrialGroup trial3(HashName("TestTrial1"), HashName("Group2"));
+ variations::SyntheticTrialGroup trial3(HashName("TestTrial1"),
+ HashName("Group2"));
service.RegisterSyntheticFieldTrial(trial3);
service.GetSyntheticFieldTrialsOlderThan(begin_log_time, &synthetic_trials);
EXPECT_EQ(1U, synthetic_trials.size());
EXPECT_TRUE(HasSyntheticTrial(synthetic_trials, "TestTrial2", "Group2"));
// Add a new trial after the log started and confirm that it doesn't show up.
- SyntheticTrialGroup trial4(HashName("TestTrial3"), HashName("Group3"));
+ variations::SyntheticTrialGroup trial4(HashName("TestTrial3"),
+ HashName("Group3"));
service.RegisterSyntheticFieldTrial(trial4);
service.GetSyntheticFieldTrialsOlderThan(begin_log_time, &synthetic_trials);
EXPECT_EQ(1U, synthetic_trials.size());
« no previous file with comments | « components/metrics/metrics_service_accessor.cc ('k') | components/omnibox.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698