chrome/android/java/res/layout/checked_text_view_with_footer.xml - Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters.

Unified Diff: chrome/android/java/res/layout/checked_text_view_with_footer.xml

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/checked_text_view_with_footer.xml

diff --git a/chrome/android/java/res/layout/checked_text_view_with_footer.xml b/chrome/android/java/res/layout/checked_text_view_with_footer.xml

new file mode 100644

index 0000000000000000000000000000000000000000..c5bb80fafed044264d62109ade82c672a143a198

--- /dev/null

+++ b/chrome/android/java/res/layout/checked_text_view_with_footer.xml

@@ -0,0 +1,25 @@

+<?xml version="1.0" encoding="utf-8"?>

newt (away) 2015/12/17 22:54:58 realistically, this layout won't be reused anywher

msramek 2016/01/11 11:39:40 Done.

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<LinearLayout

+ xmlns:android="http://schemas.android.com/apk/res/android"

+ android:orientation="vertical"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content">

+ <include

+ android:id="@+id/text"

+ layout="@layout/select_dialog_multichoice_material" />

+ <TextView

+ android:id="@+id/footer"

newt (away) 2015/12/17 22:54:58 In Android preferences, this is called the "summar

msramek 2016/01/11 11:39:40 Done. Also renamed "text" above to "title".

+ android:layout_marginTop="-15dp"

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

+ android:paddingStart="?attr/dialogPreferredPadding"

+ android:paddingEnd="?attr/dialogPreferredPadding"

+ android:textAppearance="?android:attr/textAppearanceSmall" />

newt (away) 2015/12/17 22:54:58 should you add android:textColor="?android:attr/te

msramek 2016/01/11 11:39:40 Thanks! I'll definitely take inspiration from that

+</LinearLayout>