chrome/android/java/res/layout/checked_text_view_with_footer.xml - Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/checked_text_view_with_footer.xml

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	newt (away) 2015/12/17 22:54:58 realistically, this layout won't be reused anywher realistically, this layout won't be reused anywhere else, so I'd name it something specific to the clear browsing data dialog, e.g. clear_browsing_data_dialog_item.xml msramek 2016/01/11 11:39:40 Done. Show quoted text On 2015/12/17 22:54:58, newt (OOO until 1-4) wrote: > realistically, this layout won't be reused anywhere else, so I'd name it > something specific to the clear browsing data dialog, e.g. > clear_browsing_data_dialog_item.xml Done.
	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:orientation="vertical"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content">

	11

	12 <include

	13 android:id="@+id/text"

	14 layout="@layout/select_dialog_multichoice_material" />

	15

	16 <TextView

	17 android:id="@+id/footer"
	newt (away) 2015/12/17 22:54:58 In Android preferences, this is called the "summar In Android preferences, this is called the "summary" (as opposed to the "title"). It might be nice to use the same terminology here. msramek 2016/01/11 11:39:40 Done. Also renamed "text" above to "title". Show quoted text On 2015/12/17 22:54:58, newt (OOO until 1-4) wrote: > In Android preferences, this is called the "summary" (as opposed to the > "title"). It might be nice to use the same terminology here. Done. Also renamed "text" above to "title".
	18 android:layout_marginTop="-15dp"

	19 android:layout_width="match_parent"

	20 android:layout_height="wrap_content"

	21 android:paddingStart="?attr/dialogPreferredPadding"

	22 android:paddingEnd="?attr/dialogPreferredPadding"

	23 android:textAppearance="?android:attr/textAppearanceSmall" />
	newt (away) 2015/12/17 22:54:58 should you add android:textColor="?android:attr/te should you add android:textColor="?android:attr/textColorSecondary" ? Take a look at preference.xml in the support library if you're trying to create something that looks (somewhat) like a preference. https://android.googlesource.com/platform/frameworks/support/+/master/v7/pref... msramek 2016/01/11 11:39:40 Thanks! I'll definitely take inspiration from that Show quoted text On 2015/12/17 22:54:58, newt (OOO until 1-4) wrote: > should you add android:textColor="?android:attr/textColorSecondary" ? > > Take a look at preference.xml in the support library if you're trying to create > something that looks (somewhat) like a preference. > > https://android.googlesource.com/platform/frameworks/support/+/master/v7/pref... Thanks! I'll definitely take inspiration from that file. But I'm expecting that the styling to match the mocks is going to take longer, so I'd still leave it for a separate CL.
	24

	25 </LinearLayout>

OLD	NEW