Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1530113002: Revert of Update re2 (Closed)

Created:
5 years ago by battre
Modified:
5 years ago
Reviewers:
tfarina, Nico
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org, vabr (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update re2 (patchset #8 id:140001 of https://codereview.chromium.org/1516543002/ ) Reason for revert: Dr. Memory complains about uninitialized memory (see bug). Original issue's description: > Update re2 to tip of tree. > > This version does not require any Chrome specific patches anymore. > > BUG=568119 > R=thakis@chromium.org,tfarina@chromium.org > > Committed: https://crrev.com/fd270ec705a75fd4e0883d091d9cf5204918c858 > Cr-Commit-Position: refs/heads/master@{#365347} TBR=thakis@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568119 Committed: https://crrev.com/4a00f459c73322bb608fac758972111ad4401023 Cr-Commit-Position: refs/heads/master@{#365503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6131 lines, -3247 lines) Patch
D third_party/re2/.gitignore View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/re2/AUTHORS View 1 chunk +1 line, -1 line 0 comments Download
D third_party/re2/BUILD View 1 chunk +0 lines, -121 lines 0 comments Download
M third_party/re2/BUILD.gn View 4 chunks +7 lines, -4 lines 0 comments Download
D third_party/re2/CMakeLists.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/re2/CONTRIBUTING.md View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/re2/CONTRIBUTORS View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/re2/Makefile View 13 chunks +31 lines, -53 lines 0 comments Download
M third_party/re2/README View 2 chunks +4 lines, -17 lines 0 comments Download
M third_party/re2/README.chromium View 2 chunks +23 lines, -10 lines 0 comments Download
D third_party/re2/WORKSPACE View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/re2/benchlog/benchplot.py View 1 chunk +0 lines, -98 lines 0 comments Download
M third_party/re2/doc/mksyntaxgo View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/doc/syntax.html View 10 chunks +22 lines, -43 lines 0 comments Download
M third_party/re2/doc/syntax.txt View 12 chunks +23 lines, -49 lines 0 comments Download
A third_party/re2/lib/codereview/codereview.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/re2/lib/codereview/codereview.py View 1 chunk +3565 lines, -0 lines 0 comments Download
D third_party/re2/lib/git/commit-msg.hook View 1 chunk +0 lines, -104 lines 0 comments Download
M third_party/re2/libre2.symbols View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/re2/libre2.symbols.darwin View 1 chunk +1 line, -9 lines 0 comments Download
A third_party/re2/patches/re2-android.patch View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/re2/patches/re2-libcxx.patch View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/re2/patches/re2-msan.patch View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/re2/patches/re2-msvc9-chrome.patch View 1 chunk +344 lines, -0 lines 0 comments Download
A third_party/re2/patches/remove-valgrind-code.patch View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/re2/patches/sparse-array-valgrind.patch View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/re2/re2.gyp View 2 chunks +3 lines, -4 lines 0 comments Download
D third_party/re2/re2.pc View 1 chunk +0 lines, -10 lines 0 comments Download
A third_party/re2/re2/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/re2/bitstate.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/re2/re2/compile.cc View 13 chunks +14 lines, -29 lines 0 comments Download
M third_party/re2/re2/dfa.cc View 37 chunks +94 lines, -72 lines 0 comments Download
M third_party/re2/re2/filtered_re2.h View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/re2/re2/filtered_re2.cc View 7 chunks +8 lines, -13 lines 0 comments Download
M third_party/re2/re2/make_perl_groups.pl View 3 chunks +14 lines, -20 lines 0 comments Download
M third_party/re2/re2/make_unicode_casefold.py View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/re2/re2/make_unicode_groups.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/re2/re2/mimics_pcre.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/nfa.cc View 5 chunks +5 lines, -54 lines 0 comments Download
M third_party/re2/re2/onepass.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/re2/re2/parse.cc View 34 chunks +87 lines, -143 lines 0 comments Download
M third_party/re2/re2/perl_groups.cc View 3 chunks +21 lines, -21 lines 0 comments Download
M third_party/re2/re2/prefilter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/prefilter.cc View 9 chunks +7 lines, -10 lines 0 comments Download
M third_party/re2/re2/prefilter_tree.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/re2/re2/prefilter_tree.cc View 17 chunks +36 lines, -33 lines 0 comments Download
M third_party/re2/re2/prog.h View 7 chunks +6 lines, -11 lines 0 comments Download
M third_party/re2/re2/prog.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M third_party/re2/re2/re2.h View 19 chunks +25 lines, -64 lines 0 comments Download
M third_party/re2/re2/re2.cc View 23 chunks +90 lines, -102 lines 0 comments Download
M third_party/re2/re2/regexp.h View 6 chunks +8 lines, -10 lines 0 comments Download
M third_party/re2/re2/regexp.cc View 13 chunks +14 lines, -23 lines 0 comments Download
M third_party/re2/re2/set.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/set.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/re2/re2/simplify.cc View 10 chunks +32 lines, -291 lines 0 comments Download
M third_party/re2/re2/stringpiece.h View 2 chunks +9 lines, -9 lines 0 comments Download
D third_party/re2/re2/stringpiece.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M third_party/re2/re2/testing/backtrack.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/re2/re2/testing/compile_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/re2/re2/testing/dfa_test.cc View 7 chunks +15 lines, -19 lines 0 comments Download
M third_party/re2/re2/testing/dump.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/re2/re2/testing/exhaustive2_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/exhaustive3_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/exhaustive_tester.h View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/re2/re2/testing/exhaustive_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/filtered_re2_test.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M third_party/re2/re2/testing/null_walker.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/parse_test.cc View 4 chunks +3 lines, -40 lines 0 comments Download
M third_party/re2/re2/testing/possible_match_test.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M third_party/re2/re2/testing/random_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/re2_arg_test.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/re2/re2/testing/re2_test.cc View 14 chunks +25 lines, -177 lines 0 comments Download
M third_party/re2/re2/testing/regexp_benchmark.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M third_party/re2/re2/testing/regexp_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/regexp_generator.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/re2/re2/testing/regexp_test.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/re2/re2/testing/required_prefix_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/set_test.cc View 2 chunks +3 lines, -29 lines 0 comments Download
M third_party/re2/re2/testing/simplify_test.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M third_party/re2/re2/testing/string_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/testing/string_generator.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/re2/re2/testing/tester.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/re2/re2/testing/tester.cc View 6 chunks +8 lines, -21 lines 0 comments Download
A third_party/re2/re2/testing/unicode_test.py View 1 chunk +207 lines, -0 lines 0 comments Download
M third_party/re2/re2/tostring.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M third_party/re2/re2/unicode.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/re2/unicode_casefold.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/re2/re2/unicode_casefold.cc View 8 chunks +9 lines, -20 lines 0 comments Download
M third_party/re2/re2/unicode_groups.h View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/re2/re2/unicode_groups.cc View 152 chunks +340 lines, -567 lines 0 comments Download
M third_party/re2/re2/walker-inl.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/re2/re2_test.bzl View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/re2/testinstall.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/re2/util/arena.h View 1 chunk +103 lines, -0 lines 0 comments Download
A third_party/re2/util/arena.cc View 1 chunk +168 lines, -0 lines 0 comments Download
M third_party/re2/util/atomicops.h View 4 chunks +14 lines, -114 lines 0 comments Download
M third_party/re2/util/benchmark.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M third_party/re2/util/flags.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/util/logging.h View 4 chunks +18 lines, -36 lines 0 comments Download
D third_party/re2/util/logging.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/re2/util/mutex.h View 6 chunks +17 lines, -36 lines 0 comments Download
M third_party/re2/util/pcre.h View 2 chunks +21 lines, -2 lines 0 comments Download
M third_party/re2/util/pcre.cc View 18 chunks +27 lines, -60 lines 0 comments Download
M third_party/re2/util/rune.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/re2/util/sparse_array.h View 6 chunks +15 lines, -26 lines 0 comments Download
A third_party/re2/util/sparse_array_test.cc View 1 chunk +150 lines, -0 lines 0 comments Download
M third_party/re2/util/sparse_set.h View 6 chunks +10 lines, -15 lines 0 comments Download
A third_party/re2/util/stringpiece.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/re2/util/stringprintf.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/re2/util/strutil.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M third_party/re2/util/test.h View 1 chunk +14 lines, -2 lines 0 comments Download
M third_party/re2/util/test.cc View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/re2/util/thread.h View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/re2/util/thread.cc View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/re2/util/threadwin.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/re2/util/util.h View 6 chunks +35 lines, -34 lines 0 comments Download
M third_party/re2/util/valgrind.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/re2/util/valgrind.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
battre
Created Revert of Update re2
5 years ago (2015-12-16 08:28:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530113002/1
5 years ago (2015-12-16 08:28:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 08:31:22 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-16 08:32:36 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a00f459c73322bb608fac758972111ad4401023
Cr-Commit-Position: refs/heads/master@{#365503}

Powered by Google App Engine
This is Rietveld 408576698