Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 15301003: Revert r22847: some dart2dart tests fail. (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert r22847: some dart2dart tests fail. Committed: https://code.google.com/p/dart/source/detail?r=22848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -911 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 20 chunks +124 lines, -489 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M sdk/lib/io/http_headers.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +2 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 5 chunks +3 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +2 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 8 chunks +13 lines, -372 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #1 manually as r22848 (presubmit successful).
7 years, 7 months ago (2013-05-17 13:56:17 UTC) #1
ngeoffray
TBR
7 years, 7 months ago (2013-05-17 13:56:21 UTC) #2
Johnni Winther
7 years, 7 months ago (2013-05-17 17:30:07 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698