Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 15301003: Revert r22847: some dart2dart tests fail. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_types.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 /** 7 /**
8 * If true, print a warning for each method that was resolved, but not 8 * If true, print a warning for each method that was resolved, but not
9 * compiled. 9 * compiled.
10 */ 10 */
(...skipping 1006 matching lines...) Expand 10 before | Expand all | Expand 10 after
1017 FunctionType computeFunctionType(Element element, 1017 FunctionType computeFunctionType(Element element,
1018 FunctionSignature signature) { 1018 FunctionSignature signature) {
1019 return withCurrentElement(element, 1019 return withCurrentElement(element,
1020 () => resolver.computeFunctionType(element, signature)); 1020 () => resolver.computeFunctionType(element, signature));
1021 } 1021 }
1022 1022
1023 reportWarning(Node node, var message) { 1023 reportWarning(Node node, var message) {
1024 if (message is TypeWarning) { 1024 if (message is TypeWarning) {
1025 // TODO(ahe): Don't supress these warning when the type checker 1025 // TODO(ahe): Don't supress these warning when the type checker
1026 // is more complete. 1026 // is more complete.
1027 if (identical(message.message.kind, MessageKind.NOT_ASSIGNABLE)) return;
1027 if (identical(message.message.kind, MessageKind.MISSING_RETURN)) return; 1028 if (identical(message.message.kind, MessageKind.MISSING_RETURN)) return;
1028 if (identical(message.message.kind, MessageKind.MAYBE_MISSING_RETURN)) { 1029 if (identical(message.message.kind, MessageKind.MAYBE_MISSING_RETURN)) {
1029 return; 1030 return;
1030 } 1031 }
1031 } 1032 }
1032 SourceSpan span = spanFromNode(node); 1033 SourceSpan span = spanFromNode(node);
1033 1034
1034 reportDiagnostic(span, 'Warning: $message', api.Diagnostic.WARNING); 1035 reportDiagnostic(span, 'Warning: $message', api.Diagnostic.WARNING);
1035 } 1036 }
1036 1037
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
1324 1325
1325 void close() {} 1326 void close() {}
1326 1327
1327 toString() => name; 1328 toString() => name;
1328 1329
1329 /// Convenience method for getting an [api.CompilerOutputProvider]. 1330 /// Convenience method for getting an [api.CompilerOutputProvider].
1330 static NullSink outputProvider(String name, String extension) { 1331 static NullSink outputProvider(String name, String extension) {
1331 return new NullSink('$name.$extension'); 1332 return new NullSink('$name.$extension');
1332 } 1333 }
1333 } 1334 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_types.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698