Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1529773003: [wasm] Fixed a problem with float32 stack parameters on 32 bit machines. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fixed a problem with float32 stack parameters on 32 bit machines. The code generation for pushing call parameters on the stack does not distinguish between float32 and float64 parameters because both are stored in the same registers. Therefore float32 parameters require two words on the stack. The wasm linkage, however, only considered one word on the stack for float32 parameters, which caused the problem that float32 parameters were not located correctly on the stack. I fixed the problem by considering two words for float32 parameters on the stack. R=bradnelson@chromium.org Committed: https://crrev.com/13412d669360f863dfaef665599800685e6c58e9 Cr-Commit-Position: refs/heads/master@{#32893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M src/compiler/wasm-linkage.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ahaas
5 years ago (2015-12-15 13:50:24 UTC) #1
bradnelson
lgtm
5 years ago (2015-12-15 15:38:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529773003/1
5 years ago (2015-12-15 15:38:28 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8985)
5 years ago (2015-12-15 15:42:46 UTC) #6
Michael Starzinger
LGTM.
5 years ago (2015-12-16 11:39:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529773003/1
5 years ago (2015-12-16 11:40:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 11:43:08 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-16 11:43:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13412d669360f863dfaef665599800685e6c58e9
Cr-Commit-Position: refs/heads/master@{#32893}

Powered by Google App Engine
This is Rietveld 408576698