Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/compiler/wasm-linkage.cc

Issue 1529773003: [wasm] Fixed a problem with float32 stack parameters on 32 bit machines. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-linkage.cc
diff --git a/src/compiler/wasm-linkage.cc b/src/compiler/wasm-linkage.cc
index 98ec2c84bb1132a37c4b6138054aeaab68eeddbe..2cd02a6cc47a9cb45795c55a3a89b57a9097cb3f 100644
--- a/src/compiler/wasm-linkage.cc
+++ b/src/compiler/wasm-linkage.cc
@@ -178,7 +178,11 @@ struct Allocator {
return type == kAstF32 || type == kAstF64;
}
int Words(LocalType type) {
- if (kPointerSize < 8 && (type == kAstI64 || type == kAstF64)) {
+ // The code generation for pushing parameters on the stack does not
+ // distinguish between float32 and float64. Therefore also float32 needs
+ // two words.
+ if (kPointerSize < 8 &&
+ (type == kAstI64 || type == kAstF64 || type == kAstF32)) {
return 2;
}
return 1;
« no previous file with comments | « no previous file | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698