Update BaseBubbleController's dealloc function to use

Update BaseBubbleController's dealloc function to use
unregisterFromNotifications

This patch updated BaseBubbleController's dealloc function to use
unregisterFromNotifications and updated code that uses it.

Committed: https://crrev.com/ecac2a2da73c1a36b3d964de435ea1ee6806b5ad
Cr-Commit-Position: refs/heads/master@{#365317}

[juncai, 2015-12-15 01:57:07]

juncai@chromium.org changed reviewers:
+ rsesek@chromium.org

[juncai, 2015-12-15 01:57:07]

Please review this patch.

[Robert Sesek, 2015-12-15 15:19:36]

https://codereview.chromium.org/1529713002/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
(right):

https://codereview.chromium.org/1529713002/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:257:
[[NSNotificationCenter defaultCenter] removeObserver:self];
This should be for only the specific notification registered above, using
-removeObserver:name:object: (pass nil as the object though), not for all
notifications (as the superclass may have registered others).

[juncai, 2015-12-15 17:43:56]

https://codereview.chromium.org/1529713002/diff/1/chrome/browser/ui/cocoa/web...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
(right):

https://codereview.chromium.org/1529713002/diff/1/chrome/browser/ui/cocoa/web...
chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:257:
[[NSNotificationCenter defaultCenter] removeObserver:self];
On 2015/12/15 15:19:36, Robert Sesek wrote:
> This should be for only the specific notification registered above, using
> -removeObserver:name:object: (pass nil as the object though), not for all
> notifications (as the superclass may have registered others).

Done.

[Robert Sesek, 2015-12-15 18:15:36]

LGTM

[juncai, 2015-12-15 19:09:03]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2015-12-15 19:10:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1529713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1529713002/20001

[commit-bot: I haz the power, 2015-12-15 21:22:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-15 21:23:33]

Description was changed from

==========
Update BaseBubbleController's dealloc function to use
unregisterFromNotifications

This patch updated BaseBubbleController's dealloc function to use
unregisterFromNotifications and updated code that uses it.
==========

to

==========
Update BaseBubbleController's dealloc function to use
unregisterFromNotifications

This patch updated BaseBubbleController's dealloc function to use
unregisterFromNotifications and updated code that uses it.

Committed: https://crrev.com/ecac2a2da73c1a36b3d964de435ea1ee6806b5ad
Cr-Commit-Position: refs/heads/master@{#365317}
==========

[commit-bot: I haz the power, 2015-12-15 21:23:34]

Patchset 2 (id:??) landed as
https://crrev.com/ecac2a2da73c1a36b3d964de435ea1ee6806b5ad
Cr-Commit-Position: refs/heads/master@{#365317}

[danakj, 2015-12-15 21:51:36]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-12-15 21:51:37]

Think this broke cast linux?
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/1474...

[Robert Sesek, 2015-12-15 21:55:36]

On 2015/12/15 21:51:37, danakj (behind on reviews) wrote:
> Think this broke cast linux?
>
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/1474...

No. .mm files only get compiled on Mac.