Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 1528543004: Update chooser bubble ui cocoa code (Closed)

Created:
5 years ago by juncai
Modified:
5 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@modify_base_bubble_controller_dealloc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chooser bubble ui cocoa code This patch updated chooser bubble ui cocoa code based on rsesek@'s comments at: https://codereview.chromium.org/1473393003/ BUG=492204 Committed: https://crrev.com/5d8566b68b85d50ede8e069c69e1ea9dc6693d3d Cr-Commit-Position: refs/heads/master@{#365355}

Patch Set 1 : updated chooser bubble ui cocoa code based on rsesek@'s comments #

Total comments: 2

Patch Set 2 : address rsesek@'s comments #

Total comments: 2

Patch Set 3 : address rsesek@'s comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 2 11 chunks +22 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
juncai
Please review this patch.
5 years ago (2015-12-15 02:10:09 UTC) #2
Robert Sesek
https://codereview.chromium.org/1528543004/diff/1/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h (right): https://codereview.chromium.org/1528543004/diff/1/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h#newcode43 chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h:43: ChooserBubbleDelegate* chooserBubbleDelegate_; // Weak. The naming here is correct. ...
5 years ago (2015-12-15 15:17:39 UTC) #3
juncai
https://codereview.chromium.org/1528543004/diff/1/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h (right): https://codereview.chromium.org/1528543004/diff/1/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h#newcode43 chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.h:43: ChooserBubbleDelegate* chooserBubbleDelegate_; // Weak. On 2015/12/15 15:17:38, Robert Sesek ...
5 years ago (2015-12-15 18:01:11 UTC) #4
Robert Sesek
https://codereview.chromium.org/1528543004/diff/20001/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm (right): https://codereview.chromium.org/1528543004/diff/20001/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm#newcode167 chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:167: [[NSNotificationCenter defaultCenter] removeObserver:self]; Limit this too to just the ...
5 years ago (2015-12-15 18:16:00 UTC) #5
juncai
https://codereview.chromium.org/1528543004/diff/20001/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm File chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm (right): https://codereview.chromium.org/1528543004/diff/20001/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm#newcode167 chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm:167: [[NSNotificationCenter defaultCenter] removeObserver:self]; On 2015/12/15 18:16:00, Robert Sesek wrote: ...
5 years ago (2015-12-15 18:24:11 UTC) #6
Robert Sesek
LGTM, thanks for the followup!
5 years ago (2015-12-15 18:38:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528543004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528543004/40001
5 years ago (2015-12-15 21:25:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-15 22:09:26 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-15 22:10:27 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d8566b68b85d50ede8e069c69e1ea9dc6693d3d
Cr-Commit-Position: refs/heads/master@{#365355}

Powered by Google App Engine
This is Rietveld 408576698