Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1529623002: Update the keyLocation deprecation message for M50 removal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index 058e47d387641874a117ea03f983023bd673da28..e1a2ce926190aab6dfb77f0219d9d23077983231 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -744,7 +744,7 @@ String UseCounter::deprecationMessage(Feature feature)
// Keyboard Event (DOM Level 3)
case KeyboardEventKeyLocation:
- return replacedBy("KeyboardEvent.keyLocation", "KeyboardEvent.location");
+ return "'KeyboardEvent.keyLocation' is deprecated and will be removed in M50, around April 2016. Please use 'KeyboardEvent.location' instead. See https://www.chromestatus.com/features/4997403308457984 for more details.";
jochen (gone - plz use gerrit) 2015/12/16 08:55:58 I wonder whether we should have a generator functi
philipj_slow 2015/12/18 10:56:43 Rebased!
case ConsoleMarkTimeline:
return replacedBy("console.markTimeline", "console.timeStamp");
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698